kill subscriber process when desktop is removed

[amtoine]

This is a duplicate of the stale #36 to apply the requested changed and merge the branch to master.

[amtoine]

TODO:

• make desktop_id=$(bspc query -D -d "$selected_desktop"); a standalone function inside utils/desktop.sh (see 36#discussion_r895042042)
• "have 2 functions kill_layout and kill_process" (see 36#discussion_r895042221)

[amtoine]

@phenax
would you like me to apply the changes above from the original PR, without a review?
or wrap them inside a review first?

no pressure if you do not have the time, that's just a friendly ping 😌

[phenax]

@amtoine, I think it's better if this pr contains those changes before the review if that's what you mean

[amtoine]

@amtoine, I think it's better if this pr contains those changes before the review if that's what you mean

it was my question 😋

so i'll add the changes and ping you when i'm done 😉

[amtoine]

@phenax
the first point should be addressed in b38e145c and the second in 3186fc79 😋
EDIT: and a bad typo below 👀

review can begin 💪

[phenax]

I don't get the point of this change. It was killing the process before resetting the state, now it does that after resetting the state but what does that accomplish?

[amtoine]

that is a change from the original PR, not sure what the goal was here to be honest 🤔

and, with the changes you originally requested in #36, kill_layout "$desktop" and

old_pid="$(get_desktop_options "$desktop" | valueof pid)"
kill_process "$old_pid"

should do exactly the same thing 👍

[amtoine]

change the way kill_layout gets called... desktop options in remove_listener have to be cleared before calling kill_layout,
otherwise if remove_listener is called by the subscriber process on desktop_remove event, it will kill itself before the options are cleared.

that is the original comment on the PR 👌