Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a term for "strain" #4

Closed
cmungall opened this issue Jul 3, 2024 · 8 comments · Fixed by #5
Closed

Add a term for "strain" #4

cmungall opened this issue Jul 3, 2024 · 8 comments · Fixed by #5

Comments

@cmungall
Copy link

cmungall commented Jul 3, 2024

There has been a request to add "strain" to NCBITaxon:

I think the OBO NCBITaxon rendering should utilize URIs from taxrank

Is this in scope for taxrank?

@balhoff
Copy link
Member

balhoff commented Jul 3, 2024

Sounds good to me. I don't think there is really a group of stakeholders to weigh in.

@hlapp
Copy link
Member

hlapp commented Jul 3, 2024

Certainly in scope. The one caveat is that it hasn't been actively maintained for a while. However, taxonomic ranks aren't really changing all that much, so it's not obvious what kind of maintenance there could have been that wasn't.

@hlapp
Copy link
Member

hlapp commented Jul 3, 2024

BTW, what's a little odd to me is that OLS doesn't show any hierarchy.

@balhoff
Copy link
Member

balhoff commented Jul 3, 2024

BTW, what's a little odd to me is that OLS doesn't show any hierarchy.

I don't think we have defined what the relationship is between ranks. Is_a would not be correct; maybe part_of but I'm not sure if there are exceptions.

@hlapp
Copy link
Member

hlapp commented Jul 3, 2024

Ah yes, good point. The question is maybe would there be a problem with implying the existence of, say, some family for, say, every genus whether there's some nomenclatural code that defines that family or not.

@balhoff
Copy link
Member

balhoff commented Jul 3, 2024

We could link them via skos as annotation properties, using e.g. skos:broader.

@hlapp
Copy link
Member

hlapp commented Jul 3, 2024

We could, but I think that would run the risk of messing with search implementations, which may use skos:broader as a fallback for finding term matches.

@cthoyt
Copy link
Contributor

cthoyt commented Nov 27, 2024

see #5 for a more comprehensive update to this ontology based on ranks appearing in the NCBI Taxonomy database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants