Skip to content

feat(redis): add NewWithClient to work with pre-existing client #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(redis): add NewWithClient to work with pre-existing client #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions redis/redis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,13 @@ func NewClient(options Options) (Client, error) {

return result, nil
}

// NewWithClient method creates a new `gokv.redis.Client` with given `redis.Client`.
// redis related options are ignored, only Codec is applicable
// The client is expected to be fully configured, with an address of a Redis server/cluster etc.
func NewWithClient(rc *redis.Client, options Options) *Client {
if options.Codec == nil {
options.Codec = DefaultOptions.Codec
}
return &Client{c: rc, codec: options.Codec}
Copy link
Owner

@philippgille philippgille Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NewClient currently includes a Ping call to check/establish a connection. Maybe we can do the same here, to minimize NewClient vs NewWithClient differences?

}