-
Notifications
You must be signed in to change notification settings - Fork 31
feat: Adding tags variable for the aws_iam_role resource #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Adding tags variable for the aws_iam_role resource #84
Conversation
@npalm it looks like the change I proposed was actually added as part of https://github.com/philips-labs/terraform-aws-github-oidc/releases/tag/v0.8.1, so for now I will just add some modifications to the main README.md. Please let me know if this is ok. |
Actually I just realized the |
Apologies for necroing this PR... We now tend to use provider level tagging so that all resources get tagged at the same time with the same tags. This prevents the needs to pass in all sorts of tags and potentially forget to add tags to various resources. Is there any use case for adding specific tags here or using them only on specific resources? |
As we create resources is always a good practice to keep tags for them. This PR adds the tags argument to the
aws_iam_role
resource which reads its value from thetags
variables.Tested using Terraform and Terragrunt without any issues.