Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fileset excludefile #1892

Merged
merged 54 commits into from
Jan 15, 2025
Merged

Fix fileset excludefile #1892

merged 54 commits into from
Jan 15, 2025

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Dec 31, 2024

This should fix #1890

jawira and others added 30 commits February 11, 2019 14:27
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.72%. Comparing base (579928d) to head (9dcac69).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1892      +/-   ##
============================================
+ Coverage     53.58%   53.72%   +0.13%     
  Complexity     9818     9818              
============================================
  Files           496      496              
  Lines         24738    24738              
============================================
+ Hits          13256    13290      +34     
+ Misses        11482    11448      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@siad007 siad007 added the defect label Jan 14, 2025
@siad007 siad007 added this to the 3.1.0 milestone Jan 14, 2025
@mrook mrook merged commit e731640 into phingofficial:main Jan 15, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

v3 Upgrade: $excludesFile must be of type Phing\Io\File, string given
3 participants