Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: check rustfmt and clippy in Rust build #220

Closed
wants to merge 4 commits into from
Closed

ci: check rustfmt and clippy in Rust build #220

wants to merge 4 commits into from

Conversation

boxdot
Copy link
Collaborator

@boxdot boxdot commented Dec 2, 2024 •
edited
Loading

Note: clippy check increases a CI run by ~2 min

This also checks that Cargo.lock is up-to-date.

boxdot added 3 commits December 2, 2024 18:07
@boxdot
chore: fix clippy 1.83
8270dcb 
Note: sqlx prepared statements changed because of removed trailing
whitespaces.
@boxdot
CI: check rustfmt and clippy in Rust build
002f328
@boxdot
don't run expensive rustup update
c6b8cb6
@boxdot boxdot changed the title CI: check rustfmt and clippy in Rust build ci: check rustfmt and clippy in Rust build Dec 2, 2024
kkohbrok
kkohbrok approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@kkohbrok kkohbrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Base automatically changed from dima/clippy to main December 3, 2024 09:46
@boxdot
Copy link
Collaborator Author

boxdot commented Dec 3, 2024

Was merged as part of #219

@boxdot boxdot closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkohbrok kkohbrok kkohbrok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boxdot @kkohbrok