fix: deadlock when replacing logging stream sink #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting a new stream sink in `SendToDartLogger`, we lock the global rw lock for writing. However, if the lock already contained a sink, it was droppen at the same line when replacing it. A stream sink logs a message on drop, and therefore `SendToDartLogger` tries to lock the global rw lock again, this time for reading. The lock is not reentrant, so it deadlocks. This makes sure we drop the previous sink *after* unlocking the rw lock. Fixes #225
boxdot
changed the title
raphaelrobert
requested changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting a new stream sink in
SendToDartLogger, we lock the globalrw lock for writing. However, if the lock already contained a sink, it
was droppen at the same line when replacing it. A stream sink logs a
message on drop, and therefore
SendToDartLoggertries to lock theglobal rw lock again, this time for reading. The lock is not reentrant,
so it deadlocks.
This makes sure we drop the previous sink after unlocking the rw lock.
In particular, this fixes hot restart in Flutter.
Fixes #225