-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Store
trait for unified client data access and observability
#280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store
trait providing unified client data access and observabilityStore
trait for unified client data access and observability
raphaelrobert
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks like a good starting point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new trait
Store
abstracts the access and modification of theclient data. Additionally, it adds observability to the changes in the
client data via the
Store::subscribe
method and theStoreNotification
type. The trait can be used as dependency inversionbetween the app logic and the core client crates.
Currently, only the
CoreUser
implements theStore
trait. Theobservability is implemented via the
StoreNotifier
helper structure.It is passed to the functions that modify data in the persistence layer.
The modifications are collected in a
StoreNotification
, and if thecorresponding operation succeeds, it is send to all current subscribers.
The cubits
ConversationListCubitBase
andConversationDetailsCubitBase
now observe the changes in the clientdata via the
Store
trait (instead of subscribing to the fetchedmessages).
Closes #269
Closes #254