Use VARCHAR(14) for primary key

Rollback the change. Using CHAR(14) is not recommended due to adding
padding.

sqlmigr/executor.go

@@ -31,9 +31,9 @@ func (m *Executor) Setup() error {
 	up := &bytes.Buffer{}
 
 	fmt.Fprintln(up, "CREATE TABLE IF NOT EXISTS migrations (")
-	fmt.Fprintln(up, " id          CHAR(14)  NOT NULL PRIMARY KEY,")
-	fmt.Fprintln(up, " description TEXT      NOT NULL,")
-	fmt.Fprintln(up, " created_at  TIMESTAMP NOT NULL")
+	fmt.Fprintln(up, " id          VARCHAR(14) NOT NULL PRIMARY KEY,")
+	fmt.Fprintln(up, " description TEXT        NOT NULL,")
+	fmt.Fprintln(up, " created_at  TIMESTAMP   NOT NULL")
 	fmt.Fprintln(up, ");")
 	fmt.Fprintln(up)
 

sqlmigr/executor_test.go

@@ -54,9 +54,9 @@ var _ = Describe("Executor", func() {
 
 			up := &bytes.Buffer{}
 			fmt.Fprintln(up, "CREATE TABLE IF NOT EXISTS migrations (")
-			fmt.Fprintln(up, " id          CHAR(14)  NOT NULL PRIMARY KEY,")
-			fmt.Fprintln(up, " description TEXT      NOT NULL,")
-			fmt.Fprintln(up, " created_at  TIMESTAMP NOT NULL")
+			fmt.Fprintln(up, " id          VARCHAR(14) NOT NULL PRIMARY KEY,")
+			fmt.Fprintln(up, " description TEXT        NOT NULL,")
+			fmt.Fprintln(up, " created_at  TIMESTAMP   NOT NULL")
 			fmt.Fprintln(up, ");")
 			fmt.Fprintln(up)
 			Expect(string(data)).To(Equal(up.String()))

sqlmigr/generator.go

@@ -64,8 +64,9 @@ func (g *Generator) write(filename string, data []byte, perm os.FileMode) error
 	}
 
 	if writer, ok := f.(io.Writer); ok {
-		n, err := writer.Write(data)
-		if err == nil && n < len(data) {
+		var n int
+
+		if n, err = writer.Write(data); err == nil && n < len(data) {
 			err = io.ErrShortWrite
 		}
 	}