Skip to content

Optionally enable caching of any request method #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 20, 2017
Merged

Optionally enable caching of any request method #24

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
52b1777
Enable caching of POST requests when requested
tuupola Feb 10, 2017
e0c1c0e
Make StyleCI happy
tuupola Feb 10, 2017
0a3b7c8
PSR-2 and short array syntax
tuupola Feb 11, 2017
8151701
Allow any valid request method as defined by RFC7230
tuupola Feb 13, 2017
baf4fbd
Include request body in cache key calculation
tuupola Feb 13, 2017
8d9d48c
Make StyleCI happy
tuupola Feb 13, 2017
5b21d4b
PHP 5.4 does not have ::class
tuupola Feb 13, 2017
cfa6135
Mention RFC7230 which defines valid request methods
tuupola Feb 14, 2017
8d8f8e9
Add new methods option to docblock
tuupola Feb 15, 2017
fbc1dc7
Request methods are case sensitive
tuupola Feb 15, 2017
e94b74a
Do not allow lowercase request methods
tuupola Feb 17, 2017
65d819d
Add delimiter between uri and body
tuupola Feb 17, 2017
10da16c
Remove unneeded use statement
tuupola Feb 17, 2017
9703885
Maintain cache key bc with v1.2.0
tuupola Feb 19, 2017
490da8b
Make StyleCI happy
tuupola Feb 19, 2017
727cbf0
Make StyleCI happy
tuupola Feb 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CachePlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ final class CachePlugin implements Plugin
* @var int $cache_lifetime (seconds) To support serving a previous stale response when the server answers 304
* we have to store the cache for a longer time than the server originally says it is valid for.
* We store a cache item for $cache_lifetime + max age of the response.
* @var array $methods case insensitive list of request methods which can be cached.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its case sensitive, not insensitive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes of course. Brain malfunction...

* }
*/
public function __construct(CacheItemPoolInterface $pool, StreamFactory $streamFactory, array $config = [])
Expand Down