Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving classes to a more component like structure #9

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

wickedOne
Copy link
Contributor

  • add Wikipedia and YouTube namespace and moved applicable classes. this way the code is clustered by implementation making it easier to copy paste it to your own application.

- add Wikipedia and YouTube namespace and moved applicable classes.
  this way the code is clustered by implementation making it easier
  to copy paste it to your own application.
@chr-hertel
Copy link
Member

Yes, nice idea! What do you think of dropping Rag in favor of Blog?

Wikipedia example is basically also Rag but thats only a Pattern and the real use case is around the Blog.

Just got me thinking ...

@wickedOne
Copy link
Contributor Author

yes, that makes perfectly sense indeed

@chr-hertel
Copy link
Member

Let me know if you want to follow up, otherwise i will merge later when I'm back at my laptop and continue :)

@wickedOne
Copy link
Contributor Author

wickedOne commented Dec 14, 2024

yes, i'll follow up.

another question would be: are you intending to add more code / implementation examples to this repository?
if so, perhaps having a parent namespace Implementation for YouTube, Blog, Wikipedia makes sense?

@chr-hertel
Copy link
Member

No, not yet, at least nö further plans atm

@wickedOne
Copy link
Contributor Author

alright then, changes pushed...

- rename add to blog to clarify the implementation
Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great impulse to encapsulate in namespaces for easier understanding, will follow up on the frontend stuff 👍

@chr-hertel chr-hertel merged commit c0fcd55 into php-llm:main Dec 14, 2024
1 check passed
@wickedOne wickedOne deleted the restructure branch December 14, 2024 16:00
@wickedOne
Copy link
Contributor Author

oops, yes sloppy me forgot about the templates... 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants