Skip to content

Fix LOCK_NB documented as standalone mode instead of bitmask flag#5257

Open
lacatoire wants to merge 1 commit intophp:masterfrom
lacatoire:fix/stream-lock-lock-nb-bitmask
Open

Fix LOCK_NB documented as standalone mode instead of bitmask flag#5257
lacatoire wants to merge 1 commit intophp:masterfrom
lacatoire:fix/stream-lock-lock-nb-bitmask

Conversation

@lacatoire
Copy link
Contributor

Summary

  • Move LOCK_NB out of the list of standalone lock operations in streamWrapper::stream_lock()
  • Document it as a bitmask flag to be combined with LOCK_SH, LOCK_EX, or LOCK_UN via bitwise OR
  • Consistent with how flock() already documents LOCK_NB

Fixes #4299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

streamWrapper::stream_lock() operation/mode listing is inconsistent

1 participant