Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate anonymous classes allow optional trailing commas in arg list #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

Indicate anonymous classes allow optional trailing commas in arg list #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spec/10-expressions.md
View file
Original file line number Diff line number Diff line change
@@ -616,6 +616,7 @@ object-creation-expression:
'new' class-type-designator '(' argument-expression-list ','? ')'
'new' class-type-designator
'new' 'class' '(' argument-expression-list? ')' class-base-clause? class-interface-clause? '{' class-member-declarations? '}'
'new' 'class' '(' argument-expression-list ','? ')' class-base-clause? class-interface-clause? '{' class-member-declarations? '}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should either use ',' without ?, or the existing line should be extended with ','?. Otherwise, the two productions are ambiguous, code without the comma can be parsed by either. I see this is already wildly inconsistent in the grammar, so maybe I'm missing something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? I was trying to follow the patterns I saw elsewhere in the grammar, but I can't find any information on the specification for the grammar we use, so it's difficult to understand what is meant or intended in places.

'new' 'class' class-base-clause? class-interface-clause? '{' class-member-declarations? '}'

class-type-designator:
@@ -638,6 +639,7 @@ new-variable:
new <i><a href="#grammar-class-type-designator">class-type-designator</a></i> ( <i><a href="#grammar-argument-expression-list">argument-expression-list</a></i> ,<sub>opt</sub> )
new <i><a href="#grammar-class-type-designator">class-type-designator</a></i>
new class ( <i><a href="#grammar-argument-expression-list">argument-expression-list</a></i><sub>opt</sub> ) <i><a href="14-classes.md#grammar-class-base-clause">class-base-clause</a></i><sub>opt</sub> <i><a href="14-classes.md#grammar-class-interface-clause">class-interface-clause</a></i><sub>opt</sub> { <i><a href="14-classes.md#grammar-class-member-declarations">class-member-declarations</a></i><sub>opt</sub> }
new class ( <i><a href="#grammar-argument-expression-list">argument-expression-list</a></i> ,<sub>opt</sub> ) <i><a href="14-classes.md#grammar-class-base-clause">class-base-clause</a></i><sub>opt</sub> <i><a href="14-classes.md#grammar-class-interface-clause">class-interface-clause</a></i><sub>opt</sub> { <i><a href="14-classes.md#grammar-class-member-declarations">class-member-declarations</a></i><sub>opt</sub> }
new class <i><a href="14-classes.md#grammar-class-base-clause">class-base-clause</a></i><sub>opt</sub> <i><a href="14-classes.md#grammar-class-interface-clause">class-interface-clause</a></i><sub>opt</sub> { <i><a href="14-classes.md#grammar-class-member-declarations">class-member-declarations</a></i><sub>opt</sub> }

<i id="grammar-class-type-designator">class-type-designator:</i>
1 change: 1 addition & 0 deletions spec/19-grammar.md
View file
Original file line number Diff line number Diff line change
@@ -424,6 +424,7 @@ The grammar notation is described in [Grammars section](09-lexical-structure.md#
new <i><a href="#grammar-class-type-designator">class-type-designator</a></i> ( <i><a href="#grammar-argument-expression-list">argument-expression-list</a></i> ,<sub>opt</sub> )
new <i><a href="#grammar-class-type-designator">class-type-designator</a></i>
new class ( <i><a href="#grammar-argument-expression-list">argument-expression-list</a></i><sub>opt</sub> ) <i><a href="#grammar-class-base-clause">class-base-clause</a></i><sub>opt</sub> <i><a href="#grammar-class-interface-clause">class-interface-clause</a></i><sub>opt</sub> { <i><a href="#grammar-class-member-declarations">class-member-declarations</a></i><sub>opt</sub> }
new class ( <i><a href="#grammar-argument-expression-list">argument-expression-list</a></i> ,<sub>opt</sub> ) <i><a href="#grammar-class-base-clause">class-base-clause</a></i><sub>opt</sub> <i><a href="#grammar-class-interface-clause">class-interface-clause</a></i><sub>opt</sub> { <i><a href="#grammar-class-member-declarations">class-member-declarations</a></i><sub>opt</sub> }
new class <i><a href="#grammar-class-base-clause">class-base-clause</a></i><sub>opt</sub> <i><a href="#grammar-class-interface-clause">class-interface-clause</a></i><sub>opt</sub> { <i><a href="#grammar-class-member-declarations">class-member-declarations</a></i><sub>opt</sub> }

<i id="grammar-class-type-designator">class-type-designator:</i>