Zend guard recursion protection #11812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstogov
reviewed
Jul 31, 2023
There was a problem hiding this comment.
I think this approach should work.
@iluuu1994 could you please also check the patch.
iluuu1994
reviewed
Jul 31, 2023
|
In terms of the benchmark, it might be a bit tricky to measure because current master is buggy in this behaviour and there is a regression (e.g. you can no longer do var_export in __debugInfo - not a huge deal but still regression as you could do that in 8.2). So you would need to revert all previous commits done by Tyson and measure against that instead. This is a regression fix with addition of that JSON improvemets. |
bukka
force-pushed
the
zend_guard_recursion
branch
from
530e122 to
82b328f
Compare
bukka
force-pushed
the
zend_guard_recursion
branch
from
82b328f to
fc718a8
Compare
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 24, 2023
This PR introduces a new way of recursion protection in JSON, var_dump and friends. It fixes issue in master for __debugInfo and also improves perf for jsonSerializable in some cases. More info can be found in phpGH-10020. Closes phpGH-11812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new way of recursion protection in JSON, var_dump and friends. This is alternative solution for what was done in #10020 and specifically implements the solution suggested by Dmitry in #10020 (comment) . More info can be find in that PR so I will not repeat it all here. As mentioned there, it fixes issue in master for __debugInfo and also improves perf for jsonSerializable in some cases.