Skip to content

Fix few build warnings. #18265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix few build warnings. #18265

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Apr 6, 2025

mostly litespeed SAPI.

@devnexen devnexen requested a review from bukka as a code owner April 6, 2025 20:01
SakiTakamachi
SakiTakamachi approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Although it doesn't cause a build error, would it be better to make the same correction in the following places as well?

php-src/ext/standard/mail.c

Line 448 in 87499e4

void (*sig_handler)() = NULL;

@devnexen
Fix few build warnings.
762557e 
mostly litespeed SAPI.
@devnexen devnexen force-pushed the fix_build_warnings branch from cdfa719 to 762557e Compare April 17, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakiTakamachi SakiTakamachi SakiTakamachi approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: standard SAPI: litespeed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @SakiTakamachi