Skip to content

Comments

Fix typos#1044

Closed
szepeviktor wants to merge 3 commits intophpList:release-3.7.0from
szepeviktor:typos
Closed

Fix typos#1044
szepeviktor wants to merge 3 commits intophpList:release-3.7.0from
szepeviktor:typos

Conversation

@szepeviktor
Copy link
Contributor

Description

Found few misspellings.

FCKConfig.SmileyPath = FCKConfig.BasePath + 'images/smiley/msn/' ;
FCKConfig.SmileyImages =
['regular_smile.gif','sad_smile.gif','wink_smile.gif','teeth_smile.gif','confused_smile.gif','tounge_smile.gif','embaressed_smile.gif','omg_smile.gif','whatchutalkingabout_smile.gif','angry_smile.gif','angel_smile.gif','shades_smile.gif','devil_smile.gif','cry_smile.gif','lightbulb.gif','thumbs_down.gif','thumbs_up.gif','heart.gif','broken_heart.gif','kiss.gif','envelope.gif']
['regular_smile.gif','sad_smile.gif','wink_smile.gif','teeth_smile.gif','confused_smile.gif','tongue_smile.gif','embarrassed_smile.gif','omg_smile.gif','whatchutalkingabout_smile.gif','angry_smile.gif','angel_smile.gif','shades_smile.gif','devil_smile.gif','cry_smile.gif','lightbulb.gif','thumbs_down.gif','thumbs_up.gif','heart.gif','broken_heart.gif','kiss.gif','envelope.gif']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michield
Copy link
Member

That is a lot of changes, but mostly in comments. I'm not entirely sure what the value of that is, but we can see that we process this and merge it.

Before doing that, can you sign the CLA?

Thanks

@szepeviktor
Copy link
Contributor Author

Before doing that, can you sign the CLA?

Signed.

@szepeviktor
Copy link
Contributor Author

I'm not entirely sure what the value of that is

That is mostly non-business value. E.g. when you write a mail and make a typo then you correct it.

@michield
Copy link
Member

Before doing that, can you sign the CLA?

Signed.

That wasn't recorded. Can you double check?

@szepeviktor
Copy link
Contributor Author

I get HTTP/500 on GET /cla.

@szepeviktor
Copy link
Contributor Author

My name contains an accented character: Szépe Viktor

@michield michield changed the base branch from main to release-3.7.0 June 18, 2025 22:43
@michield
Copy link
Member

I've reviewed this and even though I appreciate the effort, this is a bit too obsessive for me. Some of the "typos" are actually in variables and therefore are likely to break things. I don't think I can merge this without loads of testing and that's not worth it.

@michield michield closed this Jun 18, 2025
@szepeviktor
Copy link
Contributor Author

@michield All right, I understand you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants