Skip to content

Create a IsA expression #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions src/Expression/ForClasses/IsA.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<?php

declare(strict_types=1);

namespace Arkitect\Expression\ForClasses;

use Arkitect\Analyzer\ClassDescription;
use Arkitect\Expression\Description;
use Arkitect\Expression\Expression;
use Arkitect\Rules\Violation;
use Arkitect\Rules\ViolationMessage;
use Arkitect\Rules\Violations;

final class IsA implements Expression
{
/** @var class-string */
private string $allowedFqcn;

/**
* @param class-string $allowedFqcn
*/
public function __construct(string $allowedFqcn)
{
$this->allowedFqcn = $allowedFqcn;
}

public function describe(ClassDescription $theClass, string $because = ''): Description
{
return new Description("should inherit from: $this->allowedFqcn", $because);
}

public function evaluate(ClassDescription $theClass, Violations $violations, string $because = ''): void
{
if (!is_a($theClass->getFQCN(), $this->allowedFqcn, true)) {
$violation = Violation::create(
$theClass->getFQCN(),
ViolationMessage::selfExplanatory($this->describe($theClass, $because)),
$theClass->getFilePath()
);

$violations->add($violation);
}
}
}
112 changes: 112 additions & 0 deletions tests/Unit/Expressions/ForClasses/IsATest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
<?php

declare(strict_types=1);

namespace Arkitect\Tests\Unit\Expressions\ForClasses;

use Arkitect\Analyzer\ClassDescriptionBuilder;
use Arkitect\Expression\ForClasses\IsA;
use Arkitect\Rules\Violations;
use Arkitect\Tests\Unit\Expressions\ForClasses\IsOneOfTest\Animal\Dog;
use Arkitect\Tests\Unit\Expressions\ForClasses\IsOneOfTest\Fruit\Banana;
use Arkitect\Tests\Unit\Expressions\ForClasses\IsOneOfTest\Fruit\CavendishBanana;
use Arkitect\Tests\Unit\Expressions\ForClasses\IsOneOfTest\Fruit\DwarfCavendishBanana;
use Arkitect\Tests\Unit\Expressions\ForClasses\IsOneOfTest\Fruit\FruitInterface;
use PHPUnit\Framework\TestCase;

final class IsATest extends TestCase
{
public function test_it_should_have_no_violation_when_it_implements(): void
{
$interface = FruitInterface::class;
$isA = new IsA($interface);
$classDescription = (new ClassDescriptionBuilder())
->setFilePath('src/Foo.php')
->setClassName(CavendishBanana::class)
->addInterface($interface, 10)
->build();

$violations = new Violations();
$isA->evaluate($classDescription, $violations, '');

self::assertEquals(0, $violations->count());
}

public function test_it_should_have_no_violation_when_it_extends(): void
{
$class = Banana::class;
$isA = new IsA($class);
$classDescription = (new ClassDescriptionBuilder())
->setFilePath('src/Foo.php')
->setClassName(DwarfCavendishBanana::class)
->addExtends($class, 10)
->build();

$violations = new Violations();
$isA->evaluate($classDescription, $violations, '');

self::assertEquals(0, $violations->count());
}

public function test_it_should_have_violation_if_it_doesnt_extend(): void
{
$interface = FruitInterface::class;
$isA = new IsA($interface);
$classDescription = (new ClassDescriptionBuilder())
->setFilePath('src/Foo.php')
->setClassName(Dog::class)
->build();

$violations = new Violations();
$isA->evaluate($classDescription, $violations, '');

self::assertEquals(1, $violations->count());
self::assertEquals(
"should inherit from: $interface",
$isA->describe($classDescription, '')->toString()
);
}

public function test_it_should_have_violation_if_it_doesnt_implement(): void
{
$class = Banana::class;
$isA = new IsA($class);
$classDescription = (new ClassDescriptionBuilder())
->setFilePath('src/Foo.php')
->setClassName(Dog::class)
->build();

$violations = new Violations();
$isA->evaluate($classDescription, $violations, '');

self::assertEquals(1, $violations->count());
self::assertEquals(
"should inherit from: $class",
$isA->describe($classDescription, '')->toString()
);
}
}

namespace Arkitect\Tests\Unit\Expressions\ForClasses\IsOneOfTest\Animal;

final class Dog
{
}

namespace Arkitect\Tests\Unit\Expressions\ForClasses\IsOneOfTest\Fruit;

interface FruitInterface
{
}

class Banana implements FruitInterface
{
}

class CavendishBanana extends Banana
{
}

final class DwarfCavendishBanana extends CavendishBanana
{
}