Fix #29 - Turn ShapeType into an enum

[JoolsMcFly]

Hi!

Thought I'd give a go at #29 .

In various places shapeType was set to -1 as default value. I replaced it with ShapeType::NULL and would like feed back on that.

Thanks for reviewing!

• Fixes Change the ShapeType class to be an enum #29

[JoolsMcFly]

Hi. Is there anything I can do on my side to get this merged?
Thanks!

[williamdes]

Thank you for this improvement !

[williamdes]

What do you think @MauricioFauth ?

[JoolsMcFly]

Hi @MauricioFauth . Thanks for your feedback.

I just added a commit which turns enum cases in PascalCase and adds an Unknown type.

Lemme know what you think.

Thanks!

[MauricioFauth]

@JoolsMcFly Could you please add a Signed-off-by line to the commit message using git commit --signoff or git commit -s?

[JoolsMcFly]

@JoolsMcFly Could you please add a Signed-off-by line to the commit message using git commit --signoff or git commit -s?

Hi @MauricioFauth .
If you don't mind I'll wait until I get green light before I squash my commits and sign. Is that OK?

[JoolsMcFly]

Thanks for your review. It all makes sense and I've made required changes.

[MauricioFauth]

Great work! Thanks!

[JoolsMcFly]

Alright, squashed and signed!