Update _record_finder_form.htm #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phpr_recordfinder_update would trigger before the form had been updated with the record id. Moved the trigger to ajax complete, so it fires after the form has been updated.
typecast decimal as float, not int.
added list_name to 'on_list_column_click' data: helps controller identify which list to return when using multiple lists contained in one form. Eg. Adding lists across form tabs with ->add_form_partial
…been made. Simple inline implementation. Suggested improvements added @todo statement
|
Surprised to find there was no cancel/clear button for a form_record_finder selection, once set. You could only replace with another record which is fine for required fields but no good if the field is optional and you need to clear the assignment. |
…been made. Simple inline implementation. Suggested improvements added @todo statement
…gh to the break at case 'float'
…name.extensions can throw off apache/server redirect.
…name.extensions can throw off apache/server redirect.
…name.extensions can throw off apache/server redirect.
- Issue with class_exists not using namespaces for Phpr\Trace_Log, stopped exceptions getting logged to DB. - Phpr\Error_Log will attempt to connect to database if database connection has not yet been established.
… TIME fields as a datetime, causing errors if time fields were used in models. This update allows for a time field value to be stored in the database as entered by the user (not treated as datetime and GMT-ZEROD). This is useful in situations where you would like to store a local time for a future event. Currently datetime will always convert to GMT-0 for internationalisation, but this is not suited to scheduling future times and dates in areas with daylight savings. For example if you have an event scheduled for 15:00 12/12/2014 using datetime whilst in DST+1, the time will be stored in the database as 14:00 12/12/2014. This is fine whilst you remain in daylight savings but the scheduled events time will change to 14:00 when DST expires. With the TIME field available you have the option to schedule in local time buy using seperate DATE, TIME and TIMEZONE fields.
- can use more time formats to create object: 00:00:00 , 00:00 , 12:00 AM 12:00:00 AM - compare and time diff functions
A wrapper for vendor addition TCPDF \File\PDF::create_new() //returns default TCPDF object, ready to use.
- added breaks to all types on the switch for clarity. - set float typecasts to null if empty (NOT 0), to allow for validation->required() on float fields.
- Added jquery UI daterangepicker to jquery-ui.js - minor css update for filter checkboxes for better presentation
- included moment.js in default framework response
…helps identify calls to list actions in the controller, when a controller receives requests from multiple lists.
…arch_enabled` and `list_date_search_column`
…#anchor for the specified form tab. This allows the form tab id to be used in the the url to switch to that tab on page load. Eg. /product/123/#my_custom_tab_id
…play/log. Can take error number/constants as a | delimeted string or array - improvement: errors defined in error_reporting will output a tracelog to screen if in dev mode (backend).
…play/log. Can take error number/constants as a | delimeted string or array - improvement: errors defined in error_reporting will output a tracelog to screen if in dev mode (backend).
…play/log. Can take error number/constants as a | delimeted string or array - improvement: errors defined in error_reporting will output a tracelog to screen if in dev mode (backend).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpr_recordfinder_update would trigger before the form had been updated with the record id.
Moved the trigger to ajax complete, so it fires after the form has been updated.