Skip to content

Annotation @TYPO3\CMS\Extbase\Annotation\Inject not tokenized correctly? #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sabbelasichon opened this issue Feb 12, 2021 · 3 comments
Closed

Annotation @TYPO3\CMS\Extbase\Annotation\Inject not tokenized correctly? #59

sabbelasichon opened this issue Feb 12, 2021 · 3 comments

Comments

@sabbelasichon
Copy link
Contributor

sabbelasichon commented Feb 12, 2021 •
edited
Loading

Currently i have the problem that all annotations prefixed with @TYPO3 are not tokenized correctly by the Lexer class. The end result of the tag variable is always @TYPO. The rest is cut off.
I guess the failure is located here https://github.com/phpstan/phpdoc-parser/blob/master/src/Lexer/Lexer.php#L144 because numbers are not allowed.
I am not really sure how i can test it or prove it. If you could guide me i would be happy to fix this, if it is considered a bug
@sabbelasichon sabbelasichon mentioned this issue Feb 12, 2021
Closed
@JanTvrdik
Copy link
Collaborator

JanTvrdik commented Feb 12, 2021 •
edited
Loading

I guess we could change the pattern to @[a-z][a-z0-9-]*+

@sabbelasichon
Copy link
Contributor Author

@JanTvrdik Should i open a PR for that?

sabbelasichon added a commit to sabbelasichon/phpdoc-parser that referenced this issue Feb 15, 2021
@sabbelasichon
[TASK] Allow numbers in tags
b250000 
Relates: phpstan#59
@sabbelasichon sabbelasichon mentioned this issue Feb 15, 2021
Merged
sabbelasichon added a commit to sabbelasichon/phpdoc-parser that referenced this issue Feb 18, 2021
@sabbelasichon
[TASK] Add testcase for docblock with number
cc64267 
Relates: phpstan#59
@sabbelasichon sabbelasichon mentioned this issue Feb 18, 2021
Merged
ondrejmirtes pushed a commit that referenced this issue Feb 19, 2021
@sabbelasichon
[TASK] Add testcase for docblock with number (#61)
2ce4c66 
Relates: #59
@github-actions
Copy link

github-actions bot commented May 1, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JanTvrdik @sabbelasichon