Skip to content

[TASK] Allow numbers in tags #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

sabbelasichon
Copy link
Contributor

Relates: #59

@JanTvrdik JanTvrdik merged commit d2c01c1 into phpstan:master Feb 16, 2021
@ondrejmirtes
Copy link
Member

What I need to see is a test for this change, I don't believe one-line regex changes like that :)

@sabbelasichon
Copy link
Contributor Author

sabbelasichon commented Feb 16, 2021

@ondrejmirtes: Total agree. At least the existing ones did not break. But what could be a real test case? I thought we are going to discuss this. I came up only with contrived examples. Because the "official" ones don´t have numbers in it. Our use case in somehow special and it is only relevant in the context of our custom Rector rules.

@ondrejmirtes
Copy link
Member

Add another test in this file https://github.com/phpstan/phpdoc-parser/blob/master/tests/PHPStan/Parser/PhpDocParserTest.php, it has to fail without this regex modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants