[cs] update coding standard to allow PHP 8 and Slevomat CS 6.4 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
commented
Feb 7, 2021
| @@ -60,6 +60,7 @@ | |||
| <arg value="install"/> | |||
| <arg value="--working-dir"/> | |||
| <arg path="build-cs"/> | |||
| <arg value="--ignore-platform-reqs"/> | |||
There was a problem hiding this comment.
TomasVotruba
commented
Feb 7, 2021
Comment on lines
-25
to
-28
| <property name="usefulAnnotations" type="array" value=" | ||
| @dataProvider, | ||
| @requires | ||
| "/> |
There was a problem hiding this comment.
Not sure where this settings moved, as $usefulAnnotations is not there anymore, but coding standard is passing even without them.
TomasVotruba
force-pushed
the
tv-cs-on-php8
branch
from
1987d37 to
cc8d8fc
Compare
|
Ready to merge ✔️ |
TomasVotruba
commented
Feb 7, 2021
| @dataProvider, | ||
| @requires | ||
| "/> | ||
| <property name="enableObjectTypeHint" value="false"/> |
There was a problem hiding this comment.
This can be replaced for all the rules by setting php_version to phpcs.xml config value:
https://github.com/slevomat/coding-standard/blob/614af5a6538aa7c96c45521522b329f770105cab/SlevomatCodingStandard/Sniffs/TypeHints/ParameterTypeHintSniff.php#L92
Done in this file above:
TomasVotruba
force-pushed
the
tv-cs-on-php8
branch
from
35a4dcd to
42d4318
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See consistence/coding-standard#65