We can not assume the type of Query::getResult() if ResultType may be void #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
Normally we assume the type of
Query<ResultType>::getResult()
to bearray<ResultType>
. However, we also assume thatQuery<void>::getResult()
returns aint
(void
denotes an INSERT or DELETE query).So we can not assume the type of
Query<ResultType>::getResult()
to bearray<ResultType>
if there is a chance thatResultType
isvoid
.In this PR I change the
DynamicReturnTypeExtension
of Query::getResult() so that no return type is assumed when ResultType may be void.Note:
This has an impact on this feature when used in conjunction with template types, as this is not valid anymore:
However, this is valid: