Add rule that enforces PHPUnit naming conventions #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cs278
force-pushed
the
class-naming-rule
branch
from
918a22f to
dbfe30d
Compare
staabm
reviewed
Dec 10, 2024
Comment on lines
+66
to
+71
| if (!$class->isFinal()) { | ||
| $errors[] = RuleErrorBuilder::message(sprintf( | ||
| 'Concrete test class, \'%s\', should be declared final.', | ||
| $class->getName(), | ||
| ))->identifier('phpunit.naming')->build(); | ||
| } |
There was a problem hiding this comment.
I am not sure this "isFinal" thing is something which should be mixed with a "general naming rule".
whether tests should be final or not is a pretty opinionated decision IMO
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it. I've outlined why in this comment: #214 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#214