Skip to content

Added regression test #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Added regression test #3875

merged 1 commit into from
Mar 12, 2025

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 11, 2025

closes phpstan/phpstan#11447

was fixed with #3871

before this fix

1) PHPStan\Rules\Arrays\NonexistentOffsetInArrayDimFetchRuleTest::testBug11447
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'
+'06: Offset 'key1' might not exist on array<mixed>.
 '

/Users/m.staab/Documents/GitHub/phpstan-src/src/Testing/RuleTestCase.php:165
/Users/m.staab/Documents/GitHub/phpstan-src/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php:877

@staabm staabm marked this pull request as ready for review March 11, 2025 16:34
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit 54159bb into phpstan:2.1.x Mar 12, 2025
251 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the reg branch March 12, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants