Improve ConstantArrayType::sliceArray() with non constant integer args
#3949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
herndlm
deleted the
constant-array-slice-array-non-constant-integer-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConstantArrayType::sliceArray()is one of the more complex constant array methods I once came up with. But it can only handle constant integer offsets and lengths so far. I tried to add support for e.g. unions, but this would increase complexity even more.Currently there is an issue where it naively falls back the defaults (offset 0, length null = full array) when it encounters invalid values. Instead of that, I think it's better and safer to degrade to a general array and do the slice there to avoid incorrect types.