LocalTypeAliasesRule: report invalid type alias names #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiripudil
force-pushed
the
invalid-type-alias-check
branch
from
bde92c7 to
730f4bd
Compare
ondrejmirtes
requested changes
Apr 18, 2021
| $aliasNameResolvedType = $this->typeNodeResolver->resolve(new IdentifierTypeNode($aliasName), $nameScope->bypassTypeAliases()); | ||
| if (!($aliasNameResolvedType instanceof ObjectType) | ||
| && !($aliasNameResolvedType instanceof TemplateType) // aliases take precedence over type parameters, this is reported by other rules using TemplateTypeCheck | ||
| || in_array($aliasName, ['self', 'parent'], true) |
There was a problem hiding this comment.
- The parentheses around
instanceofaren't necessary,!$foo instanceof Fooworks - But I'd like parentheses disambiguating
$foo && $bar || $baz, I honestly don't know what happens :) So there should be either($foo && $bar) || $bazor$foo && ($bar || $baz)
There was a problem hiding this comment.
Ha, I guess that's some quirk of codesniffer then. When I had the disambiguating parentheses there, it reported "Useless parentheses" and since removing them helped, I didn't know it meant those parentheses around instanceof.
|
BTW do we have covered also |
Now we do :) it also helped make the parentheses less messy |
jiripudil
force-pushed
the
invalid-type-alias-check
branch
from
b9fffc8 to
ea781c7
Compare
|
I had to add back the behaviour removed in e381f0b: the resolution in the rule here actually has to bypass type aliases, otherwise it would report false positives for every alias which references a non-ObjectType 😟 |
ondrejmirtes
approved these changes
Apr 19, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up of #460