Update getArgument return type in interact method #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Griffon-Weglot
approved these changes
May 20, 2024
ondrejmirtes
requested changes
May 30, 2024
| } | ||
|
|
||
| $method = $scope->getFunction(); | ||
| if ($method instanceof MethodReflection && $method->getName() === 'interact') { |
Member
There was a problem hiding this comment.
You should also check the declaring class of the method. You might not be in a console command at all.
Contributor
Author
There was a problem hiding this comment.
I added a new check 1dfe119
I'm not sure if there is a more optimised method for this.
VincentLanglet
force-pushed
the
interactArgs
branch
from
c508fd7 to
1dfe119
Compare
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #256 (cc @alexander-schranz)
By design, all the arguments can be null in Command::interact method.
Doing
in the interact method is reported as an error by PHPStan so there is currently no satisfying solution except ignoring the error. And updating the dynamic return type extension seems doable.