Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using messenger HandleTrait as QueryBus with appropriate result typing #423

Draft
wants to merge 1 commit into
base: 1.4.x
Choose a base branch
from
Draft

using messenger HandleTrait as QueryBus with appropriate result typing #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions tests/Type/Symfony/data/messenger_handle_trait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,3 +111,32 @@ public function __invoke()
assertType('mixed', $this->handle(new MultiHandlersForTheSameMessageQuery()));
}
}

class QueryBus {
use HandleTrait;

public function dispatch(object $query): mixed
{
return $this->handle($query);
}
Comment on lines +116 to +121
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add this test case with changed function name.

Suggested change
use HandleTrait;
public function dispatch(object $query): mixed
{
return $this->handle($query);
}
use HandleTrait {
handle as private handleQuery;
}
public function handle(object $query): mixed
{
return $this->handleQuery($query);
}

}

class Controller {
public function action()
{
$queryBus = new QueryBus();

assertType(RegularQueryResult::class, $queryBus->dispatch(new RegularQuery()));

assertType('bool', $queryBus->dispatch(new BooleanQuery()));
assertType('int', $queryBus->dispatch(new IntQuery()));
assertType('float', $queryBus->dispatch(new FloatQuery()));
assertType('string', $queryBus->dispatch(new StringQuery()));

assertType(TaggedResult::class, $queryBus->dispatch(new TaggedQuery()));

// HandleTrait will throw exception in fact due to multiple handle methods/handlers per single query
assertType('mixed', $queryBus->dispatch(new MultiHandlesForInTheSameHandlerQuery()));
assertType('mixed', $queryBus->dispatch(new MultiHandlersForTheSameMessageQuery()));
}
}
Loading