-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support V8 10.5 #490
Support V8 10.5 #490
Conversation
|
If you've compiled V8 in default configuration it'll have sandbox enabled. If so, you need to pass
|
With these changes php-v8js compiles just fine with V8 10.5.81 and also passes the test suite. Please note that this PR is based on php7 branch, hence I've tried PHP 7.4.3 This PR needs some more love, especially
But feel free to already give it a try, give feedback and tell whether it works for you. cc @temuri416 |
V8 10.5 uses c++17 features (
is_lvalue_reference_v
), hence we need to adapt our config process to detect c++17 and use that (opposed to c++14 like we did before)With that configuration works, compilation seems to pass pretty far but in the end fails with
Needs to be "investigated" where that function went to :)
refs #489