Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust scanning, override SEARCH_PATH by explicitly given dir #534

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

stesie
Copy link
Member

@stesie stesie commented Sep 20, 2024

See my remarks at #532 (comment)

@JoshuaBehrens

Copy link
Contributor

@JoshuaBehrens JoshuaBehrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the issue you mentioned there. Sounds like a good approach to me

maybe we should also update the README files, telling that it's now also possible to use the libs that are shipped with Debian, Ubuntu, ...

This might be the right pull request to add this?

@redbullmarky
Copy link
Collaborator

Tested on Ubuntu 24 and worked a treat!
So nice to be able to get it up-and-running so quickly without a full V8 download/compile!

@stesie stesie merged commit aac40cd into phpv8:php8 Sep 24, 2024
@stesie
Copy link
Member Author

stesie commented Sep 24, 2024

@JoshuaBehrens see d1af93e ... I updated the instructions already (a bit). but feel free to follow-up with a PR, if you think we should add more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants