Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci test on alpine #538

Merged
merged 2 commits into from
Sep 29, 2024
Merged

add ci test on alpine #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21d6286
add ci test on alpine
stesie Sep 29, 2024
eaf4b73
skip array_access_002 test, broken on V8 11.3.244.8
stesie Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,45 @@ jobs:
./configure --with-v8js=/opt/v8/self-built LDFLAGS="-lstdc++" CPPFLAGS="-DV8_COMPRESS_POINTERS -DV8_ENABLE_SANDBOX"
make
make test

- name: Archive test results
if: failure()
uses: actions/upload-artifact@v4
with:
name: phpt-test-results
path: |
php_test_results*.txt
tests/*.out

alpine:
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this how one runs alpine on GitHub Workflows? :D weird concept but if it works

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, found it weird as well :)

... but there's no runner image with alpine


steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Setup latest Alpine Linux
uses: jirutka/setup-alpine@v1

- name: Install dependencies
run: |
cat /etc/alpine-release
apk add php83-dev nodejs-dev g++ make
shell: alpine.sh --root {0}

- name: Build extension
run: |
phpize
./configure
make
make test
shell: alpine.sh {0}

- name: Archive test results
if: failure()
uses: actions/upload-artifact@v4
with:
name: phpt-test-results
path: |
php_test_results*.txt
tests/*.out
8 changes: 7 additions & 1 deletion tests/array_access_002.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
--TEST--
Test V8::executeString() : Use ArrayAccess with JavaScript native push method
--SKIPIF--
<?php require_once(dirname(__FILE__) . '/skipif.inc'); ?>
<?php require_once(dirname(__FILE__) . '/skipif.inc');

if (str_starts_with(V8Js::V8_VERSION, '11.3.244.8')) {
die("skip V8 version known to call setter twice");
}

?>
--INI--
v8js.use_array_access = 1
--FILE--
Expand Down
Loading