Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IPv6 in Unbound config by default #1010

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Conversation

ThomasKramps
Copy link
Contributor

@ThomasKramps ThomasKramps commented Mar 24, 2024

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Wouldn't it be a good idea to enable IPv6 by now?

How does this PR accomplish the above?:

This PR changes the unbound config to enable IPv6 by default.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Wouldn't it be a good idea to enable IPv6 by now?

Signed-off-by: ThomasKramps <[email protected]>
@ThomasKramps ThomasKramps changed the title Update unbound.md Enable IPv6 in Unbound config by default Mar 24, 2024
Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit d74cee0
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/67b1d83e057c7f00088024a9
😎 Deploy Preview https://deploy-preview-1010--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DL6ER
Copy link
Member

DL6ER commented Mar 25, 2024

What happens if the system doesn't have IPv6? They still happens a lot today, especially worth mentioning inside most docker containers.

@rdwebdesign
Copy link
Member

As far as I know, docker IPv6 is disabled by default and even when enabled, some features are still considered experimental:

Also, it only works in Linux (it doesn't work on Docker Desktop for Windows/Mac)

Personally, I don't think this option should be set as default.

@ThomasKramps
Copy link
Contributor Author

Hm, I wasn't aware of the docker situation. I'm using the normal Linux installation.

I just tested the suggested config in a docker container (without IPv6-Support) and had no issues. Everything still works fine.

@jameskimmel
Copy link
Contributor

Seems like unbound also has it enabled by default.
https://unbound.docs.nlnetlabs.nl/en/latest/manpages/unbound.conf.html#server-options

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no harm in enabling it. Unbound will be smart enough to re-send the query via IPv4 if there is no IPv6 connectivity.
I personally run unbound with do-ip6:yes as a docker container and it works fine.

@yubiuser yubiuser requested a review from a team February 13, 2025 21:57
@DL6ER
Copy link
Member

DL6ER commented Feb 14, 2025

Previously, we had it disabled because debug log level showed that it always tried to send via IPv6 and this caused a lot of timeouts on non-IPv6 setups. This may have changed. Together with prefer-ip6: no it should be fine as in: not do much if anything

@yubiuser
Copy link
Member

@ThomasKramps this branch is out-of-date. Please rebase on 'master'

@ThomasKramps
Copy link
Contributor Author

Rebranched on master. ”prefer-ipv6: no“ is still set. So ready to merge now?

@yubiuser yubiuser merged commit bcd306b into pi-hole:master Feb 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants