-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable IPv6 in Unbound config by default #1010
Conversation
Wouldn't it be a good idea to enable IPv6 by now? Signed-off-by: ThomasKramps <[email protected]>
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What happens if the system doesn't have IPv6? They still happens a lot today, especially worth mentioning inside most |
As far as I know, docker IPv6 is disabled by default and even when enabled, some features are still considered experimental: ![]() Also, it only works in Linux (it doesn't work on Docker Desktop for Windows/Mac) Personally, I don't think this option should be set as default. |
Hm, I wasn't aware of the docker situation. I'm using the normal Linux installation. I just tested the suggested config in a docker container (without IPv6-Support) and had no issues. Everything still works fine. |
Seems like unbound also has it enabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no harm in enabling it. Unbound will be smart enough to re-send the query via IPv4 if there is no IPv6 connectivity.
I personally run unbound with do-ip6:yes
as a docker container and it works fine.
Previously, we had it disabled because debug log level showed that it always tried to send via IPv6 and this caused a lot of timeouts on non-IPv6 setups. This may have changed. Together with |
@ThomasKramps this branch is out-of-date. Please rebase on 'master' |
Rebranched on master. ”prefer-ipv6: no“ is still set. So ready to merge now? |
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Wouldn't it be a good idea to enable IPv6 by now?
How does this PR accomplish the above?:
This PR changes the unbound config to enable IPv6 by default.
By submitting this pull request, I confirm the following:
git rebase
)