Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mojave updates #11

Open
wants to merge 1,719 commits into
base: master
Choose a base branch
from
Open

Mojave updates #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1719 commits
Select commit Hold shift + click to select a range
0633fbb
Merge pull request #61 from tiennou/optimize
tiennou Mar 14, 2017
6a19521
Update icon with a 10.10-style frame
nanotech Jan 30, 2017
c2a9795
Remove the previous app icon
nanotech Mar 15, 2017
7da0ce8
Merge pull request #73 from nanotech/f/new-icon
tiennou Mar 16, 2017
fb0e1ec
Fix open panel only accepting files
mangerlahn Mar 16, 2017
3b6e0bd
Remove methods unrecognized from NSMenuItem
mangerlahn Mar 31, 2017
0af0dcf
Switch to using calloc there, for overflows' sake
tiennou Jan 15, 2017
d9a28ce
Add some debugging
tiennou Jan 15, 2017
2c106f0
We like C++
tiennou Mar 14, 2017
104ddc8
Make that public, for the time-being
tiennou Mar 14, 2017
2b3a2b7
Fixes #17
tiennou Mar 14, 2017
4bc3720
Cleanup
tiennou Mar 14, 2017
8f66be5
Merge pull request #19 from tiennou/fix/missing-parents
tiennou Mar 31, 2017
bcb221e
Fix an issue where clicking a remote would not select the correct commit
tiennou Apr 11, 2017
b6abb42
Disable the CFNetwork diagnotics for the time being
tiennou Apr 11, 2017
ef41ba0
Added "Open Submodule" menu item to contextual menu of submodules
ksuther Jul 10, 2013
33c134b
Remove unused speedtest.h
ksuther Apr 23, 2017
3f7fc20
Remove RoundedRectangle category
ksuther Apr 23, 2017
4731f60
Remove dead reference to gitx.icns and gitx_icon.psd
ksuther Apr 23, 2017
a8f50d8
Moved cli tool and gitx_askpasswd source files into separate groups t…
ksuther Apr 23, 2017
89e4914
Remove old references to private Quick Look API
ksuther Apr 23, 2017
c38e607
Remove unused method
ksuther Apr 23, 2017
83dd66c
Mark parents as copy so it is stored as a NSArray instead of NSMutabl…
ksuther Apr 23, 2017
9a7a24d
sign in PBGitCommit isn't used
ksuther Apr 23, 2017
cb08fdc
Remove redundant init
ksuther Apr 24, 2017
99ca9ac
Fixed leaked object hierarchies when closing a repository
ksuther Apr 24, 2017
97e67f6
Fixed PBGitCommitController leak
ksuther Apr 24, 2017
9e233ca
Merge pull request #81 from ksuther/open-submodule-menu-item
tiennou Apr 24, 2017
80d528a
Merge pull request #82 from ksuther/project-cleanup
tiennou Apr 24, 2017
3b21df2
Merge pull request #83 from ksuther/memory-leak
tiennou Apr 24, 2017
a2344f1
Change Travis to Xcode 8.3
ksuther Apr 24, 2017
d7648a0
Travis: Specify the scheme to build. Use the workspace instead of the…
ksuther Apr 24, 2017
2819644
worksspace -> workspace
ksuther Apr 24, 2017
8b39202
Use xcodebuild on Travis instead of relying on xctool
ksuther Apr 24, 2017
4e9bcfa
Merge pull request #84 from ksuther/travis-xcode83
tiennou Apr 24, 2017
8166376
Add xcpretty
tiennou Apr 24, 2017
6ea2dbf
Make RepoWatcher ivars private
tiennou Apr 24, 2017
2d26259
Modern NS_ENUM for watcher event types
tiennou Apr 24, 2017
02cc2bb
instancetype-ify
tiennou Apr 24, 2017
7273da7
Bring the small WatcherEventPath inline
tiennou Apr 24, 2017
9e9c495
Free our FSEventStreamRefs on -dealloc
tiennou Apr 24, 2017
425a0f6
Move the path-filtering to the event callback
tiennou Apr 24, 2017
1202ad3
Make gitDir & workDir properties dependent on the repository
tiennou Apr 25, 2017
91b24b6
Use a single event stream per repository
tiennou Apr 25, 2017
e450c60
Fixed missing General preferences icon
ksuther Apr 25, 2017
7a1ceca
Merge pull request #87 from ksuther/general-icon
tiennou Apr 25, 2017
e2c4b6e
UInt32 => NSUInteger
tiennou Apr 25, 2017
34d00fe
Use NSFileManager prefetching for the isDirectory test
tiennou Apr 25, 2017
155e441
Don't synthesize ivars
tiennou Apr 25, 2017
8fed755
Nullability annotations
tiennou Apr 25, 2017
df68065
Point URLs to our GitHub project page
tiennou Apr 25, 2017
bce27c7
Always show entries in the file list, even when there is no diff
tiennou Mar 31, 2017
e720387
TODO--
tiennou Mar 31, 2017
c309a2a
Make the diff parsing prefix-agnostic
tiennou Mar 31, 2017
b514f06
Merge pull request #80 from tiennou/fix/diff-mnemonics
tiennou Apr 25, 2017
4af0422
Merge pull request #85 from tiennou/fix/fs-events-leaks
tiennou Apr 25, 2017
94da0b6
The wrong userInfo is being passed here
tiennou Mar 14, 2017
743c531
When there is both a failure reason and a recovery suggestion, displa…
tiennou Apr 25, 2017
241e39c
Change a few errors to the new functions
tiennou Apr 25, 2017
b6eb32a
Fixed missing commit hook error message
ksuther Apr 26, 2017
399eb50
Converted PBCommitHookFailedSheet to Auto Layout
ksuther Apr 26, 2017
1aef490
Switch to using NSOperation and NSOperationQueue in PBGitRevList
ksuther Apr 28, 2017
b4b8498
Change Amend Commit menu item to use an action instead of bindings.
ksuther May 2, 2017
7057740
Fix for indexing forever spinner
Jun 6, 2017
90effc3
Merge pull request #97 from claybridges/fix-task
claybridges Jun 8, 2017
070e312
Merge pull request #89 from ksuther/commit-hook-fix
tiennou Jul 4, 2017
9ad6e91
Merge pull request #75 from mangerlahn/fix-open-panel
tiennou Jul 4, 2017
c2b4659
Merge pull request #95 from ksuther/fix-amend-menu-item
tiennou Jul 4, 2017
9c4534e
Fix disabled Amend commit menu item
tiennou Jul 4, 2017
b8d69df
Ask for confirmation before trashing files
tiennou Jul 4, 2017
5b65b95
Switch to Auto Layout split views to simplify code
ksuther Apr 24, 2017
830267b
Commit text view wasn't being sized to match the scroll view, which w…
ksuther Apr 24, 2017
87016f7
Added NSSplitView category to restore autosaved split view positions …
ksuther Apr 25, 2017
5491ea0
Cleaned up commit and staging split views.
ksuther Apr 25, 2017
b09abc2
Removed dangling outlet that was logging a warning at launch
ksuther Apr 25, 2017
0a13f5a
Opening multiple documents will now use the same window size
ksuther Apr 25, 2017
3d969fe
updateQuicklookForce: shouldn't do anything if the sharedPreviewPanel…
ksuther Jul 5, 2017
e55b4a4
Remove incorrect at-synthesize declarations
tiennou Jul 19, 2017
899ca98
Merge pull request #88 from ksuther/split-view
tiennou Nov 26, 2017
4a894d4
Fix #102 by closing the fileHandle
mangerlahn Dec 2, 2017
0e185d7
Merge pull request #104 from mangerlahn/feature/fix-background-cpu-usage
tiennou Dec 4, 2017
5a1bbfa
build.py: Remove argh dependency
zertosh Dec 25, 2017
ad13b37
Merge pull request #107 from zertosh/no-argh
tiennou Jan 18, 2018
eff1058
history.js: extract inline regex to textToHTML function
muhqu Feb 1, 2018
34b5947
history.js: adjust hyperlink regex to not break...
muhqu Feb 1, 2018
9a69e97
Complete fix for #106.
tiennou Feb 5, 2018
d6c780f
Don't include repositories that have been deleted or moved in Open Re…
ksuther Feb 12, 2018
75b2691
finishedGraphing wasn't getting called when updateHistoryForRev:
ksuther Feb 12, 2018
72ae476
Fix #108
Feb 13, 2018
d75584c
Merge pull request #111 from muhqu/fix-hyperlinks
tiennou Feb 13, 2018
03e354e
Merge pull request #115 from ksuther/missing-repositories-in-open-recent
tiennou Feb 13, 2018
1e05f19
Merge pull request #92 from ksuther/nsoperation-for-gitrevlist
tiennou Feb 13, 2018
5f63934
Move the task wrangling out to PBTask
tiennou Feb 21, 2017
d02a281
Add environment managing to PBTask
tiennou Feb 22, 2017
d5645d9
Add an `inDirectory` variant to our nicer methods
tiennou Feb 22, 2017
db8f097
Give access to the output data as an UTF-8 string
tiennou Feb 22, 2017
32fe24a
Stash the task's output in the error when execution fails
tiennou Mar 14, 2017
097c456
Add a way to schedule blocks on specific queues
tiennou Jun 9, 2017
d35616d
Add a -description
tiennou Mar 14, 2017
5ee7be1
Actually report whether the task was successful or not
tiennou Mar 14, 2017
42cc839
Stringify the task's arguments when reporting errors
tiennou Mar 15, 2017
5abdea0
Blacklist some more env vars
tiennou Jun 7, 2017
affa0a7
Fix hang caused by task data output size
tiennou Jun 7, 2017
96485d8
Break retain cycle caused by retaining our task inside blocks
tiennou Jun 7, 2017
a4102a3
Task debug logging
tiennou Jun 7, 2017
c793307
Don't close our read handle if there's still data available
tiennou Jan 29, 2018
3d35946
Fix a double-free by synchronizing task reading
tiennou Jan 29, 2018
638e567
Comment that we might need a check when writing to tasks
tiennou Feb 13, 2018
ff5b674
Split the `git`-using methods in a category
tiennou Feb 22, 2017
60a9500
Change a few methods to PBTask
tiennou Feb 22, 2017
424b462
Import PBTask from the category so it doesn't get sprinkled everywhere
tiennou Mar 14, 2017
8a5bbd3
Switch the history search to PBTask
tiennou Mar 14, 2017
9dcedbd
More PBTask-ing
tiennou Mar 14, 2017
69931be
Switch PBWebController to PBTask
tiennou Jun 9, 2017
1a8bf1c
Switch PBGitXProtocol to PBTask
tiennou Jun 9, 2017
200c14e
De-deprecate
tiennou Jan 29, 2018
0943934
Removed unnecessary #imports of PBEasyPipe.h
ksuther Feb 11, 2018
85909e5
Remove extra calls to readDataToEndOfFile that were causing exceptions
ksuther Feb 11, 2018
f65baf9
Add NSError parameters to PBGitRepository methods
tiennou Feb 20, 2017
aa9c41f
Remove backward-compatibility layer
tiennou Feb 17, 2017
59a85f1
PBGitRepository isn't part of the controller hierarchy anymore
tiennou Feb 20, 2017
25281b0
Unused method
tiennou Mar 14, 2017
882f680
De-deprecate those
tiennou Mar 14, 2017
13c9ba1
Use the 10.9+ method of handling sheets and add a completion handler
tiennou Feb 18, 2017
34bfb3e
Use the completion handler to perform the branch creation
tiennou Feb 18, 2017
fdc8169
Use the handler for the message sheets
tiennou Feb 18, 2017
39bcff4
Use the handler for the tag creation sheet
tiennou Feb 18, 2017
d3d0435
Use the "canonical" API for this
tiennou Feb 18, 2017
0f73408
Unused method
tiennou Apr 2, 2017
bbb9583
Mark -init as unavailable
tiennou Apr 2, 2017
704da4b
Wire Cmd-. to cancel action
tiennou Apr 2, 2017
8b665e8
Add API to hide sheets so that another one can be displayed
tiennou Apr 2, 2017
1016bf9
Move dialog #defines in PBGitDefaults
tiennou Apr 2, 2017
417fd99
Modernize PBRemoteProgressSheet API
tiennou Feb 13, 2018
24d9455
Make RJModalRepoSheet work with application-modal alerts
tiennou Jun 7, 2017
eb80af5
Switch add remote to the modern sheet API
tiennou Feb 13, 2018
7a78662
Switch fetch methods to the new sheet API
tiennou Feb 13, 2018
5904e63
Switch pull function to the new sheet API
tiennou Feb 13, 2018
3272331
Move push function to the new sheet API
tiennou Feb 13, 2018
6a8c9b9
Make clone panel use the new sheet API
tiennou Feb 13, 2018
2f1fdd8
Remove all the deprecated sheet API
tiennou Feb 13, 2018
35ac5b8
Rewire -createBranch: to the first responder
tiennou Feb 13, 2018
82d5c27
Revert "Comment that we might need a check when writing to tasks"
tiennou Feb 14, 2018
19cf7be
Ensure KVO notifications are sent from the main thread
tiennou Feb 15, 2018
fede5a7
Enhance error messages when additional data is available
tiennou Feb 15, 2018
d9b3333
Beautify error messages
tiennou Feb 15, 2018
1d4a7e8
Unused method
tiennou Feb 15, 2018
8866c52
Use Objective-Git to get the list of remotes
tiennou Feb 15, 2018
1e93339
Correct reversed postIndexRefresh argument
tiennou Feb 15, 2018
14f473a
Remove unused deprecated PBGitBinarySupport methods
tiennou Feb 15, 2018
5e4d922
Incorrect return on error function
tiennou Feb 23, 2018
81a665f
Fix a crash when having HEAD detached
tiennou Feb 25, 2018
0913e06
Reenable deprecation warnings
tiennou Feb 25, 2018
78a7388
Update last few "trivial" uses to PBTask
tiennou Feb 25, 2018
57365cf
Make our context menu items use the responder chain
tiennou Feb 25, 2018
c16d5ad
Move IBActions out of PBRefController into PBGitHistoryController
tiennou Feb 25, 2018
004d7b7
Rewire delete-reference sheet
tiennou Feb 25, 2018
08c77bd
Copy-pasting things from the history list is handled at the window level
tiennou Feb 25, 2018
cbcba80
Rewire diff context menu item
tiennou Feb 25, 2018
2e63424
Rewire stash actions
tiennou Feb 25, 2018
40c88c8
Rewire tag info action
tiennou Feb 25, 2018
1ec4f02
Merge pull request #117 from tiennou/develop
tiennou Feb 25, 2018
4a8ad68
Make context menu items work with remote branch
tiennou Feb 25, 2018
e3f1422
Update Objective-Git to 0.27-mostly
tiennou Feb 25, 2018
225fbd5
Correct wiring of hook-failed sheet actions
tiennou Feb 26, 2018
1722a2d
Report actual hook output
tiennou Feb 26, 2018
1c430c9
Remove deprecated methods
tiennou Feb 26, 2018
24af2cc
Set the SBApplication instance's sendMode to kAENoReply to speed up h…
ksuther Feb 28, 2018
5f3975d
Fix code injection bugs (XSS) in HTML views
nanotech Mar 7, 2018
4820fdc
Add CSPs to mitigate XSS via inline scripts and styles
nanotech Mar 7, 2018
de442fa
Merge pull request #120 from ksuther/gitx-sendMode
tiennou Mar 14, 2018
5120b6c
Remove unused ivar
tiennou Mar 14, 2018
8ca76ad
Fix indentation consistency
nanotech Mar 14, 2018
9f20ed1
Fix error when opening a repository with an unborn master branch
tiennou Feb 27, 2018
3179090
Show unborn status in document title
tiennou Feb 27, 2018
7ab0a9c
Finalize context menu actions for fetch/push/pull/delete
tiennou Feb 27, 2018
513e6b1
Ignore task termination when performing searches
tiennou Mar 14, 2018
d72100a
Prevent textconv from being made when searching
tiennou Mar 14, 2018
ede70b1
Override -document so it has the correct type
tiennou Mar 15, 2018
893d9e1
Grab the repository from the document instead of through the initializer
tiennou Mar 15, 2018
fe4b10e
Remove unused method on PBViewController
tiennou Mar 15, 2018
ad8e5ba
Keep track of refs using NSMenuItem -representedObject instead of ivars
tiennou Mar 15, 2018
93d05ed
Remove PBRefMenuItem subclass
tiennou Mar 15, 2018
25621b3
Reorder methods so actions are all in one place
tiennou Mar 15, 2018
85318a7
Rewire fetch and fix a few issues
tiennou Mar 15, 2018
a92319c
Move all menuitem-related actions to the window controller
tiennou Mar 16, 2018
f8a6ba7
Merge pull request #124 from nanotech/xss
tiennou Mar 16, 2018
61b1718
wip
mxcl Mar 27, 2018
86e2648
Split view is vertical
mxcl Mar 27, 2018
5ca6d60
Tweaks to commits list
mxcl Mar 27, 2018
7557837
Sign with Codebase account
mxcl Mar 27, 2018
7b27c92
More commit list tweaks
mxcl Mar 27, 2018
546ffa0
wip
mxcl Mar 27, 2018
3fc75e0
Time ago tweak
mxcl Mar 27, 2018
0c8ec85
Main window tweaks
mxcl Mar 27, 2018
3ba36c5
Update bundle IDs
mxcl Mar 27, 2018
29adf4a
Overlooked ago alteration
mxcl Mar 27, 2018
fb7d2b2
Commit view pretty++
mxcl Mar 27, 2018
ba362e5
Hide duplicated crap in right pane
mxcl Mar 27, 2018
878f93c
Update README.markdown
mxcl Mar 27, 2018
fc9c452
Remove scope bar
mxcl Mar 27, 2018
dda2024
Delete unused submodules
mxcl Mar 27, 2018
86a7fe4
warning--
mxcl Mar 27, 2018
1912145
Update Xcode 9.3 stuff
mxcl Mar 27, 2018
b39a45e
Remove stuff we don't care about
mxcl Mar 27, 2018
615437e
Fix the sodding `gitx --client` command; damn
mxcl Mar 28, 2018
4bab0e3
Include a Screenshot
mxcl Mar 28, 2018
68bfe93
Make the history controller responsible of the main search method
tiennou Apr 13, 2018
e11f6b9
Flatten forward class definitions
tiennou Apr 13, 2018
78734e3
Make the main controller the owner of the main controllers
tiennou Apr 13, 2018
96a494c
Make the main menu item aware of the commit list
tiennou Apr 13, 2018
0921c6a
Checkout a branch when it is double-clicked in the sidebar
Mar 16, 2018
78e75b2
Align commit view elements (#141)
elia Apr 24, 2018
8133974
Merge pull request #135 from Timmmm/doubleclick_branches_checkout
tiennou Apr 24, 2018
e2b5713
Close our subview controllers when the window closes
tiennou Apr 23, 2018
84324d1
Disable ASan
tiennou Apr 13, 2018
433d63d
Default to the last stash when no stash is provided
tiennou Apr 13, 2018
c06dd3d
When no message is provided, use a lightweight tag
tiennou Apr 13, 2018
b84ea02
Clarify typing of PBGitRepository ivars
tiennou Apr 13, 2018
2a3b99d
Re-enable remote deletion
tiennou Apr 23, 2018
ba0ba3b
Update Objective-Git to master
tiennou Jun 19, 2018
27f778d
Add a nicer description to PBGitRef
tiennou Jun 25, 2018
9cb1339
Rewire the push menu
tiennou Jun 25, 2018
4327f69
Copy-paste error
tiennou Jun 25, 2018
627c902
Don't swallow the pull error by mistake
tiennou Jun 25, 2018
97b287a
Wrap the task status as a signed short if it's low
tiennou Jun 25, 2018
760d7c6
Rewire rebase
tiennou Jun 25, 2018
00b90de
Fix a bug with the gitx argument handling
tiennou Jun 26, 2018
19a5bb8
Make sure we don't try to handle arguments for multiple files
tiennou Jun 26, 2018
71d6c77
Update Objective-Git to master (take 2)
tiennou Jun 26, 2018
61de520
Wire support for revspec in enumerator
tiennou Jun 29, 2018
73553aa
Restore `gitx -- path` filtering
tiennou Jun 29, 2018
7da571b
Merge remote-tracking branch 'gitx/master'
mxcl Aug 8, 2018
7e8aaef
Render commit list dots dark if Mojave dark-mode
mxcl Aug 8, 2018
055af28
Invert all CSS colors
mxcl Aug 9, 2018
ea60f07
Replace Menlo with SF Mono; fix commit color
mxcl Aug 9, 2018
72cb80e
`gitx` install instructions
mxcl Mar 30, 2018
27a309d
Darkmode screenshot
mxcl Aug 9, 2018
731f508
Removed submodule obj-git
mxcl Sep 27, 2018
3283f18
Bundle brew’d openssl dylibs
mxcl Sep 29, 2018
7a41b8f
Move status items to (tool/title)bar
mxcl Sep 29, 2018
866c9c0
Some string fixes
mxcl Sep 29, 2018
e57de6f
Remove source list, add segmented control to title
mxcl Sep 29, 2018
3794f98
Fix Terminal Apple Events
mxcl Sep 30, 2018
c8f07d3
Updates for Xcode 10
mxcl Oct 2, 2018
03d6c01
Remove quick-look loading
mxcl Oct 2, 2018
b959885
Update screenshot
mxcl Oct 7, 2018
965fa5f
Dark theme only
mxcl Oct 9, 2018
a485d58
--Typo
mxcl Oct 9, 2018
7fb83ba
Update README.markdown
mxcl Oct 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
15 changes: 7 additions & 8 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
build
build/revision
*.xcodeproj/*.pbxuser
*.xcodeproj/*.perspectivev3
*.xcodeproj/*.mode1v3
*.xcodeproj/*.tm_build_errors
*.tmproj
Nightly.app.zip
stats/
build/
DerivedData/
/release/
.DS_Store
__pycache__/
*.pyc
6 changes: 3 additions & 3 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[submodule "libgit2"]
path = libgit2
url = git://github.com/pieter/libgit2.git
[submodule "SyntaxHighlighter"]
path = External/SyntaxHighlighter
url = https://github.com/alexgorbatchev/SyntaxHighlighter.git
38 changes: 0 additions & 38 deletions ApplicationController.h
View file
Open in desktop

This file was deleted.

Loading