Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: ci: updated github actions ci workflow #148

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Backport: ci: updated github actions ci workflow #148

wants to merge 1 commit into from

Conversation

Phillip9587
Copy link
Contributor

Backport of #143

@Phillip9587 Phillip9587 changed the title ci: updated github actions ci workflow Backport: ci: updated github actions ci workflow Nov 25, 2024
@wesleytodd
Copy link
Member

I pushed it just to see if the CI was still failing and why, and it looks to me like the error we saw from a bad supertest/superagent release.

ladjs/supertest#851

@wesleytodd
Copy link
Member

Hm, we are on the 6.x line. Maybe something else is up?

@wesleytodd
Copy link
Member

Haha, every node version that failed failed with a different error. That is for sure messed up, and likely not at all related to this change or even the tests failing. While I see we are on the 6.x supertest I am still very suspicious of this failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleytodd wesleytodd wesleytodd approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phillip9587 @wesleytodd @UlisesGascon