Added several properties to tab panel#2640
Merged
Merged
Conversation
|
vin0401
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Related to https://github.com/pimcore/portal-engine/pull/820
Additional info
This pull request improves the flexibility of the
Tabpanelcomponent by adding support for controlled and uncontrolled tab selection. The main changes are the addition ofdefaultActiveKey,activeKey, andonChangeprops toTabpanel, allowing parent components to manage which tab is active or respond to tab changes. The implementation ensures these props are correctly passed down to the underlying tab system, while also cleaning up unused props in theTabscomponent.Enhancements to tab selection and control:
defaultActiveKey,activeKey, andonChangeprops to theTabpanelPropsinterface and passed them through theTabpanelcomponent, enabling both controlled and uncontrolled tab usage. [1] [2] [3]onChangeprop from theTabscomponent implementation, ensuring that tab change handling is now managed at theTabpanellevel. [1] [2]