-
Notifications
You must be signed in to change notification settings - Fork 108
Better version sorting #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have remote list sorted correctly by default for better readability latest version selection (in case `-rc*` versions are used).
Take advantage of Debian's convention of using ~ for pre-release suffixes.
pimlie
requested changes
Oct 2, 2020
@pimlie The Perl dependency is gone, is there something else? |
pimlie
reviewed
Nov 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on parsing the versions here, much cleaner this way!
Have two small remarks, mainly to avoid confusion in the future.
Btw, I guess this pr would resolve this issue too? #39
pimlie
approved these changes
Dec 9, 2020
Thanks for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have remote list sorted correctly by default for better readability latest version selection (in case
-rc*
versions are used).Previous output of
ubuntu-mainline-kernel -r v5.8. --rc
:Updated output: