Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run test roms #60

Merged
merged 13 commits into from
Jul 10, 2024
Merged

Run test roms #60

merged 13 commits into from
Jul 10, 2024

Conversation

joajfreitas
Copy link
Collaborator

Run test roms

@joajfreitas joajfreitas force-pushed the run_test_roms2 branch 12 times, most recently from c7080aa to afad615 Compare July 7, 2024 19:41
@joajfreitas joajfreitas force-pushed the run_test_roms2 branch 4 times, most recently from ebf21cc to 9ba8bd6 Compare July 8, 2024 20:47
@joajfreitas joajfreitas force-pushed the run_test_roms2 branch 2 times, most recently from e3d8d32 to 9817a46 Compare July 9, 2024 21:38
pineman
pineman requested changes Jul 9, 2024
View reviewed changes
Copy link
Owner

@pineman pineman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so we don't forget - our normal tests aren't running in CI. We should do cargo test and then cargo test --ignored

@joajfreitas joajfreitas merged commit 8f7f1ef into main Jul 10, 2024
1 check passed
@joajfreitas joajfreitas deleted the run_test_roms2 branch July 10, 2024 17:53
@joajfreitas joajfreitas added the enhancement New feature or request label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pineman pineman pineman approved these changes

Assignees

@pineman pineman

@joajfreitas joajfreitas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joajfreitas @pineman