Skip to content

Conversation

@cicada-lewis
Copy link

@cicada-lewis cicada-lewis commented Jan 13, 2026

Closes #6234 #6322

#6472 very thx for this pr

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 13, 2026

Hi @cicada-lewis. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 13, 2026

Welcome @cicada-lewis! It looks like this is your first PR to pingcap/tidb-operator 🎉

@pingcap-cla-assistant
Copy link

pingcap-cla-assistant bot commented Jan 13, 2026

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/M label Jan 13, 2026
@liubog2008
Copy link
Member

/run-all-tests

@liubog2008
Copy link
Member

/ok-to-test

@cicada-lewis
Copy link
Author

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-1.x@b7be2d8). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.x    #6653   +/-   ##
==============================================
  Coverage               ?   65.71%           
==============================================
  Files                  ?      267           
  Lines                  ?    39347           
  Branches               ?        0           
==============================================
  Hits                   ?    25857           
  Misses                 ?    11416           
  Partials               ?     2074           
Flag Coverage Δ
e2e 47.93% <70.00%> (?)
unittest 57.54% <40.00%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liubog2008
Copy link
Member

/run-pull-e2e-kind
/run-pull-e2e-kind-across-kubernetes

@cicada-lewis
Copy link
Author

cicada-lewis commented Jan 13, 2026

#6472 very thx for this pr

@cicada-lewis
Copy link
Author

/run-all-tests
/run-pull-e2e-kind
/run-pull-e2e-kind-across-kubernetes

@liubog2008
Copy link
Member

/run-all-tests

@cicada-lewis
Copy link
Author

/run-all-tests

1 similar comment
@liubog2008
Copy link
Member

/run-all-tests

@liubog2008
Copy link
Member

/run-pull-e2e-kind
/run-pull-e2e-kind-across-kubernetes
/run-pull-e2e-kind-br

1 similar comment
@liubog2008
Copy link
Member

/run-pull-e2e-kind
/run-pull-e2e-kind-across-kubernetes
/run-pull-e2e-kind-br

@liubog2008
Copy link
Member

/run-pull-e2e-kind
/run-pull-e2e-kind-across-kubernetes
/run-pull-e2e-kind-br

@liubog2008
Copy link
Member

/run-pull-e2e-kind

1 similar comment
@liubog2008
Copy link
Member

/run-pull-e2e-kind

@liubog2008
Copy link
Member

/run-pull-e2e-kind-across-kubernetes

@liubog2008
Copy link
Member

/run-pull-e2e-kind-br

3 similar comments
@liubog2008
Copy link
Member

/run-pull-e2e-kind-br

@liubog2008
Copy link
Member

/run-pull-e2e-kind-br

@liubog2008
Copy link
Member

/run-pull-e2e-kind-br

@liubog2008
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 16, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-16 06:00:17.656947881 +0000 UTC m=+128045.270904737: ☑️ agreed by liubog2008.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liubog2008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 16, 2026
@ti-chi-bot ti-chi-bot bot merged commit 7080620 into pingcap:release-1.x Jan 16, 2026
14 of 15 checks passed
@liubog2008
Copy link
Member

/cherry-pick release-1.6

@ti-chi-bot
Copy link
Member

@liubog2008: new pull request created to branch release-1.6: #6662.

Details

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants