Skip to content

[WIP] feat: implement primary transfer functionality for Resource Manager #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
okJiang wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[WIP] feat: implement primary transfer functionality for Resource Manager #6661

okJiang wants to merge 10 commits into from

Conversation

@okJiang
Copy link
Member

@okJiang okJiang commented Jan 16, 2026 •
edited
Loading

ref #6660

Scale PD FeatureTable  scale and rolling restart resource manager 3 to 5 [c:PD, op:Scale]
/home/admin/tidb-operator/tests/e2e/suite/scale/pd.go:112
  STEP: Creating a namespace e2e-tidb-operator-vdduc @ 01/20/26 15:34:05.703
  STEP: Creating a cluster @ 01/20/26 15:34:05.718
  STEP: Creating a pd group @ 01/20/26 15:34:05.723
  STEP: Creating a resource manager group @ 01/20/26 15:34:05.739
  STEP: wait for pd group ready @ 01/20/26 15:34:05.744
  STEP: wait for resource manager group ready @ 01/20/26 15:34:35.759
  STEP: scale e2e-tidb-operator-vdduc/rmg to 5 and rolling restart @ 01/20/26 15:34:40.775
  STEP: wait for resource manager group ready @ 01/20/26 15:35:50.788
  STEP: Delete the cluster: tc @ 01/20/26 15:36:00.804
  STEP: Ensure the cluster: tc can be deleted @ 01/20/26 15:36:00.809
  STEP: Delete the namespace e2e-tidb-operator-vdduc @ 01/20/26 15:36:15.816
  STEP: Ensure the namespace e2e-tidb-operator-vdduc can be deleted @ 01/20/26 15:36:15.819
• [165.122 seconds]
------------------------------
Scale PD FeatureTable [UsePDReadyAPIV2] scale and rolling restart resource manager 3 to 5 [c:PD, op:Scale, f:UsePDReadyAPIV2]
/home/admin/tidb-operator/tests/e2e/suite/scale/pd.go:112
  STEP: Creating a namespace e2e-tidb-operator-midhq @ 01/20/26 15:36:50.826
  STEP: Creating a cluster @ 01/20/26 15:36:50.831
  STEP: Creating a pd group @ 01/20/26 15:36:50.835
  STEP: Creating a resource manager group @ 01/20/26 15:36:50.84
  STEP: wait for pd group ready @ 01/20/26 15:36:50.844
  STEP: wait for resource manager group ready @ 01/20/26 15:37:30.859
  STEP: scale e2e-tidb-operator-midhq/rmg to 5 and rolling restart @ 01/20/26 15:37:30.868
  STEP: wait for resource manager group ready @ 01/20/26 15:38:40.88
  STEP: Delete the cluster: tc @ 01/20/26 15:38:50.897
  STEP: Ensure the cluster: tc can be deleted @ 01/20/26 15:38:50.902
  STEP: Delete the namespace e2e-tidb-operator-midhq @ 01/20/26 15:39:05.906
  STEP: Ensure the namespace e2e-tidb-operator-midhq can be deleted @ 01/20/26 15:39:05.909
• [170.088 seconds]
------------------------------
Scale PD FeatureTable  scale and rolling restart resource manager 5 to 3 [c:PD, op:Scale]
/home/admin/tidb-operator/tests/e2e/suite/scale/pd.go:113
  STEP: Creating a namespace e2e-tidb-operator-oabhp @ 01/20/26 15:39:40.915
  STEP: Creating a cluster @ 01/20/26 15:39:40.919
  STEP: Creating a pd group @ 01/20/26 15:39:40.923
  STEP: Creating a resource manager group @ 01/20/26 15:39:40.927
  STEP: wait for pd group ready @ 01/20/26 15:39:40.931
  STEP: wait for resource manager group ready @ 01/20/26 15:40:15.945
  STEP: scale e2e-tidb-operator-oabhp/rmg to 3 and rolling restart @ 01/20/26 15:40:15.957
  STEP: wait for resource manager group ready @ 01/20/26 15:41:20.97
  STEP: Delete the cluster: tc @ 01/20/26 15:41:25.984
  STEP: Ensure the cluster: tc can be deleted @ 01/20/26 15:41:25.989
  STEP: Delete the namespace e2e-tidb-operator-oabhp @ 01/20/26 15:41:40.994
  STEP: Ensure the namespace e2e-tidb-operator-oabhp can be deleted @ 01/20/26 15:41:40.997
• [155.089 seconds]
------------------------------
Scale PD FeatureTable [UsePDReadyAPIV2] scale and rolling restart resource manager 5 to 3 [c:PD, op:Scale, f:UsePDReadyAPIV2]
/home/admin/tidb-operator/tests/e2e/suite/scale/pd.go:113
  STEP: Creating a namespace e2e-tidb-operator-kjhif @ 01/20/26 15:42:16.004
  STEP: Creating a cluster @ 01/20/26 15:42:16.009
  STEP: Creating a pd group @ 01/20/26 15:42:16.014
  STEP: Creating a resource manager group @ 01/20/26 15:42:16.019
  STEP: wait for pd group ready @ 01/20/26 15:42:16.023
  STEP: wait for resource manager group ready @ 01/20/26 15:42:56.041
  STEP: scale e2e-tidb-operator-kjhif/rmg to 3 and rolling restart @ 01/20/26 15:42:56.052
  STEP: wait for resource manager group ready @ 01/20/26 15:44:01.065
  STEP: Delete the cluster: tc @ 01/20/26 15:44:06.078
  STEP: Ensure the cluster: tc can be deleted @ 01/20/26 15:44:06.085
  STEP: Delete the namespace e2e-tidb-operator-kjhif @ 01/20/26 15:44:21.092
  STEP: Ensure the namespace e2e-tidb-operator-kjhif can be deleted @ 01/20/26 15:44:21.095
• [165.098 seconds]

PD Availability Test NextGen PDMS No error when rolling update resource manager in next-gen [c:PD, k:Avail, op:Update, Serial, k:NextGen, P0, f:UsePDReadyAPIV2, f:UseTSOReadyAPI, f:UseSchedulingReadyAPI]
/home/admin/tidb-operator/tests/e2e/suite/availability/pd.go:118
  STEP: Creating a namespace e2e-tidb-operator-vjswx @ 01/20/26 15:28:20.858
  STEP: Creating a cluster @ 01/20/26 15:28:20.879
  Forwarding from 127.0.0.1:35963 -> 9000
  Forwarding from [::1]:35963 -> 9000
  Handling connection for 35963
  STEP: Creating a pd group @ 01/20/26 15:28:31.779
  STEP: Creating a tikv group @ 01/20/26 15:28:31.796
  STEP: Creating a tidb group @ 01/20/26 15:28:31.801
  STEP: Creating a tso group @ 01/20/26 15:28:31.808
  STEP: Creating a scheduler group @ 01/20/26 15:28:31.812
  STEP: Creating a resource manager group @ 01/20/26 15:28:31.817
  STEP: wait for pd group ready @ 01/20/26 15:28:31.821
  STEP: wait for tikv group ready @ 01/20/26 15:30:01.832
  STEP: wait for tidb group ready @ 01/20/26 15:30:01.84
  STEP: wait for tso group ready @ 01/20/26 15:30:01.852
  STEP: wait for scheduling group ready @ 01/20/26 15:30:01.86
  STEP: wait for resource manager group ready @ 01/20/26 15:30:01.868
  STEP: Creating PD region access job @ 01/20/26 15:30:01.879
  STEP: rolling restart e2e-tidb-operator-vjswx/rmg @ 01/20/26 15:30:06.888
  STEP: wait for resource manager group ready @ 01/20/26 15:30:36.901
  STEP: Stop workload job @ 01/20/26 15:30:46.91
  Forwarding from 127.0.0.1:44103 -> 8080
  Forwarding from [::1]:44103 -> 8080
  Handling connection for 44103
  STEP: Stop job successfully @ 01/20/26 15:30:46.932
  STEP: Delete the cluster: tc @ 01/20/26 15:30:51.891
  STEP: Ensure the cluster: tc can be deleted @ 01/20/26 15:30:51.896
  STEP: Delete the namespace e2e-tidb-operator-vjswx @ 01/20/26 15:32:11.902
  STEP: Ensure the namespace e2e-tidb-operator-vjswx can be deleted @ 01/20/26 15:32:11.906
• [251.055 seconds]

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign shuijing198799 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge January 16, 2026 09:04
@github-actions github-actions bot added the v2 for operator v2 label Jan 16, 2026
@okJiang okJiang changed the title feat: implement primary transfer functionality for Resource Manager [WIP] feat: implement primary transfer functionality for Resource Manager Jan 16, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 40.00000% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.34%. Comparing base (ddd7385) to head (9beb9c8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6661      +/-   ##
==========================================
+ Coverage   38.31%   38.34%   +0.03%     
==========================================
  Files         368      373       +5     
  Lines       21422    21630     +208     
==========================================
+ Hits         8207     8294      +87     
- Misses      13215    13336     +121
Flag Coverage Δ
unittest 38.34% <40.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

liubog2008
liubog2008 reviewed Jan 19, 2026
View reviewed changes
pkg/controllers/resourcemanager/tasks/transfer_primary.go Outdated
tlsConfig = cfg
}

hc := &http.Client{Timeout: defaultAPITimeout, Transport: &http.Transport{TLSClientConfig: tlsConfig}}
Copy link
Member

@liubog2008 liubog2008 Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not new client every time. Connections will leak. If you need a pd client, use pd client manager

@okJiang
update image
c1d318e 
Signed-off-by: okjiang <[email protected]>
@okJiang
add scale and rolling restart test
b8edf30 
Signed-off-by: okjiang <[email protected]>
@okJiang
keep order same as tso
2633cb1 
Signed-off-by: okjiang <[email protected]>
@okJiang
feat: add Resource Manager client functionality and integrate into re…
02d26c4 
…conciler

Signed-off-by: okjiang <[email protected]>
@okJiang
fix delete rmg
fb551b2 
Signed-off-by: okjiang <[email protected]>
@okJiang
feat: integrate PDClient into resource manager tasks for primary tran…
7b376de 
…sfer

Signed-off-by: okjiang <[email protected]>
@okJiang
fix lint and verify
ee34c20 
Signed-off-by: okjiang <[email protected]>
@okJiang
gengo
ceac59c 
Signed-off-by: okjiang <[email protected]>
@okJiang
update pd's config when deploy resource manager
9beb9c8 
Signed-off-by: okjiang <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 21, 2026

@okJiang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e 9beb9c8 link true /test pull-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liubog2008 liubog2008 liubog2008 left review comments

@shonge shonge Awaiting requested review from shonge

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

do-not-merge/work-in-progress size/XXL v2 for operator v2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@okJiang @codecov-commenter @liubog2008