-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errno: Add missing error codes to pkg/errno from pkg/parser/mysql. #59237
base: master
Are you sure you want to change the base?
errno: Add missing error codes to pkg/errno from pkg/parser/mysql. #59237
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @wddevries. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59237 +/- ##
================================================
+ Coverage 73.0585% 73.4956% +0.4371%
================================================
Files 1689 1689
Lines 467012 467052 +40
================================================
+ Hits 341192 343263 +2071
+ Misses 104846 102831 -2015
+ Partials 20974 20958 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hi, after checking the linked issue I see most of the missing error codes are features that TiDB does not implemented. And the package |
What problem does this PR solve?
Issue Number: ref #29026
Problem Summary:
There are two copies of most error codes and error messages.
What changed and how does it work?
This pull request:
This pull request is the first step in removing the mysql error codes and error messages from the parser.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.