Skip to content

Conversation

@Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from nexustar and srstack November 24, 2025 06:16
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 27.94118% with 49 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/fts@5e178b3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
components/playground/main.go 37.50% 19 Missing and 1 partial ⚠️
components/playground/playground.go 21.43% 7 Missing and 4 partials ⚠️
components/playground/instance/tiflash_config.go 0.00% 6 Missing ⚠️
components/playground/instance/tiflash.go 0.00% 1 Missing and 2 partials ⚠️
components/playground/instance/pd_config.go 0.00% 0 Missing and 2 partials ⚠️
components/playground/instance/tici_meta_config.go 0.00% 2 Missing ⚠️
components/playground/instance/tikv_config.go 0.00% 0 Missing and 2 partials ⚠️
components/playground/instance/tikv_worker.go 0.00% 2 Missing ⚠️
components/playground/instance/tidb_config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             feature/fts    #2651   +/-   ##
==============================================
  Coverage               ?   47.80%           
==============================================
  Files                  ?      344           
  Lines                  ?    36923           
  Branches               ?        0           
==============================================
  Hits                   ?    17648           
  Misses                 ?    17099           
  Partials               ?     2176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Lloyd-Pottiger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants