Skip to content

Add VS Code Insiders and VSCodium to Open In editor picker#1392

Merged
juliusmarminge merged 1 commit intopingdotgg:mainfrom
nassimna:feature/open-in-vscode-family
Mar 27, 2026
Merged

Add VS Code Insiders and VSCodium to Open In editor picker#1392
juliusmarminge merged 1 commit intopingdotgg:mainfrom
nassimna:feature/open-in-vscode-family

Conversation

@nassimna
Copy link
Copy Markdown
Contributor

@nassimna nassimna commented Mar 25, 2026

Adds VS Code Insiders and VSCodium to the existing Open In editor flow.
open-picker-demo

What changed:

  • extend shared editor contracts with vscode-insiders and vscodium
  • use per-editor supportsGoto metadata so --goto works for both editors
  • update the web Open menu to surface the new editors when installed
  • add server and browser tests for availability detection, picker filtering, and open dispatch

Why:

  • this follows the existing editor integration pattern instead of introducing a separate code path
  • the change is scoped to the current Open In feature only
  • behavior stays predictable: editors only appear when their CLI is available on PATH

Validation:

  • bun run test src/open.test.ts in apps/server
  • bun run test:browser src/components/ChatView.browser.tsx in apps/web
  • bun fmt
  • bun lint
  • bun typecheck

Note

Low Risk
Low risk: scoped to editor picker/launch wiring and editor availability detection, with added test coverage; main risk is incorrect CLI mapping or --goto behavior for the new editors.

Overview
Adds VS Code Insiders (code-insiders) and VSCodium (codium) as supported targets in the “Open in editor” flow, surfacing them in the web picker only when detected as installed.

Extends the shared EDITORS contract with per-editor supportsGoto metadata and updates server launch resolution to use it so line/column paths use --goto for all supporting editors. Updates/expands server + browser tests to cover availability detection, picker filtering, selection/fallback behavior, and open dispatch for the new editors.

Written by Cursor Bugbot for commit 78661af. This will update automatically on new commits. Configure here.

Note

Add VS Code Insiders and VSCodium to the Open In editor picker

  • Adds vscode-insiders and vscodium editor definitions to packages/contracts/src/editor.ts, each with supportsGoto=true, and exposes them in the picker in apps/web/src/components/chat/OpenInPicker.tsx.
  • Refactors shouldUseGotoFlag in apps/server/src/open.ts to accept a full editor definition object and use the supportsGoto flag, replacing the previous hardcoded check for cursor and vscode.
  • Adds a supportsGoto boolean to all existing editor definitions (zed, antigravity, and file-manager set to false).
  • Behavioral Change: --goto is now driven by supportsGoto on the editor definition rather than a hardcoded id list, so any future editor with supportsGoto=true will automatically get line/column support.

Macroscope summarized 78661af.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 09c9b058-2983-47f7-8a1f-2cd7ab175bea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nassimna nassimna force-pushed the feature/open-in-vscode-family branch from 7cbfe80 to 3796c2f Compare March 25, 2026 00:23
@nassimna nassimna force-pushed the feature/open-in-vscode-family branch from 3796c2f to 78661af Compare March 27, 2026 01:47
@github-actions github-actions bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 27, 2026
@juliusmarminge juliusmarminge enabled auto-merge (squash) March 27, 2026 04:45
@juliusmarminge juliusmarminge merged commit 648f067 into pingdotgg:main Mar 27, 2026
11 checks passed
aaditagrawal pushed a commit to aaditagrawal/t3code that referenced this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants