fix(desktop): default confirm dialog selection to "No"#1400
Open
Efroim-Propel wants to merge 1 commit intopingdotgg:mainfrom
Open
fix(desktop): default confirm dialog selection to "No"#1400Efroim-Propel wants to merge 1 commit intopingdotgg:mainfrom
Efroim-Propel wants to merge 1 commit intopingdotgg:mainfrom
Conversation
The confirm dialog defaultId was set to the "Yes" button, causing users to instinctively press the non-highlighted safe option and unintentionally cancel destructive actions like thread deletion.
UtkarshUsername
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kept hitting "delete thread" and nothing was happening, it took me a minute to realize the confirm dialog defaults to "Yes", so I was instinctively clicking the non-highlighted "No" button.
I changed the
defaultIdto0so that "No" is highlighted by default, which is the standard for destructive confirmations. I double checked all call sites, and all usages are for delete/revert/reset actions, so defaulting to the safe option makes sense everywhere.