fix(server): prevent git auth loops during passive status refresh#1433
fix(server): prevent git auth loops during passive status refresh#1433ifBars wants to merge 4 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c36240a448
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What Changed
statusDetails().fetchUpstreamRefForStatustimeout so Git Credential Manager login can complete when that scheduled refresh needs auth on Windows.Why
On Windows, the desktop app could repeatedly open and close the GitHub/GCM auth window while the app was focused.
This happened when passive status polling triggered
git fetchin a repo without cached GitHub credentials. In that state, Git Credential Manager needs time for the user to complete interactive login. The previous implementation awaited upstream refresh directly insidestatusDetails()with a 5 second timeout, which killed the fetch before auth could finish and restarted the same flow on the next refresh.This change keeps the longer auth window allowance on the passive refresh path, but removes that auth-sensitive fetch from blocking callers like
statusDetails(),pushCurrentBranch(), andpullCurrentBranch().Fixes #1418
Checklist