Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: For a javascript ajax call, set the return code instead of default 200 in error view exception handler #1637

Merged
merged 3 commits into from
May 31, 2024

Conversation

liyaqin1
Copy link
Contributor

@liyaqin1 liyaqin1 commented May 31, 2024

@liyaqin1 liyaqin1 requested a review from a team as a code owner May 31, 2024 00:04
@github-actions github-actions bot added the deploy-board Includes changes to deploy-board label May 31, 2024
tylerwowen
tylerwowen previously approved these changes May 31, 2024
@gzpcho
Copy link
Contributor

gzpcho commented May 31, 2024

Would be good to see if we can address the TODO on this fie:

# TODO so we are using this as the catch ALL, and report error, as the last resort
# this is fine, except the exception stack trace is not particularly user-friendly
# We should not depends on this too much, but in the code handle as much exception
# as we can and generate user friendly message there.

@liyaqin1 liyaqin1 merged commit c67d381 into master May 31, 2024
5 checks passed
@liyaqin1 liyaqin1 deleted the liyaqin1-patch-3 branch May 31, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-board Includes changes to deploy-board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants