-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit launch latency #1696
Merged
Merged
Emit launch latency #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a6a6b6
to
2e9c31a
Compare
osoriano
reviewed
Aug 16, 2024
deploy-service/common/src/main/java/com/pinterest/deployservice/handler/GoalAnalyst.java
Outdated
Show resolved
Hide resolved
osoriano
previously approved these changes
Aug 16, 2024
fc90fd5
to
e281689
Compare
osoriano
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TAS
Previously launch latency was emitted by a Rodimus worker. This PR implements the same measure in the TAS.
Launch latency is defined as the duration from host launch to the the complete of the first deployment. It measures for all environments deployed on new hosts. The configuration Launch grace period is the user set threshold for this latency and it's used for AgentJanitor and Rodimus health check.
Another fix is that I found all first deploy metrics were success. So I updated the condition when the
first_deploy
flag should be turned off.UI
While updating the group status page to include the launch latency, I realized I forgot that the original plan was to create a dashboard. So I removed the links added in #1694, created a dashboard including the changes in a new Teletraan user dashboard.
Fixed launch failure rate graph and updated some metrics calculations.
Test plan
TAS
UI