Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format all java code #1777

Closed

Conversation

osoriano
Copy link
Contributor

@osoriano osoriano commented Feb 6, 2025

Formatted all the java code twice, since after the first format command, the history is updated and it needs another format.
Verified that running the formatter again does not produce an additional changes.

Ran:

mvn spotless:apply -DspotlessSetLicenseHeaderYearsFromGitHistory=true
git commit -am "Format all java code"
mvn spotless:apply -DspotlessSetLicenseHeaderYearsFromGitHistory=true
git commit -am "Format all java code, again"

@osoriano osoriano requested a review from a team as a code owner February 6, 2025 00:02
@osoriano osoriano requested a review from tylerwowen February 6, 2025 00:02
@github-actions github-actions bot added the deploy-service Includes changes to deploy-service label Feb 6, 2025
@osoriano
Copy link
Contributor Author

osoriano commented Feb 6, 2025

I was able to work around this by removing the DspotlessSetLicenseHeaderYearsFromGitHistory from the formatter command

@osoriano osoriano closed this Feb 6, 2025
@osoriano osoriano deleted the osoriano/format-all-java-code branch February 6, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-service Includes changes to deploy-service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant