Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates SCTP association creation from the sctp.Config struct API to the newer ClientWithOptions functional options API, updating dependency versions accordingly.
Changes:
- Replace
sctp.Client(sctp.Config{...})usage withsctp.ClientWithOptions(...)inSCTPTransport.Start. - Introduce helper methods to build the SCTP client options list, including conditional (optional) options.
- Add a unit test to ensure optional SCTP options are included when enabled, and bump
github.com/pion/sctptov1.9.3.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sctptransport.go |
Migrates SCTP client initialization to ClientWithOptions and centralizes option construction. |
sctptransport_test.go |
Adds coverage ensuring optional SCTP settings result in additional options being passed. |
go.mod |
Updates github.com/pion/sctp dependency to v1.9.3. |
go.sum |
Updates checksums corresponding to the SCTP dependency bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fippo
approved these changes
Mar 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3397 +/- ##
==========================================
+ Coverage 85.51% 85.53% +0.02%
==========================================
Files 81 81
Lines 9746 9761 +15
==========================================
+ Hits 8334 8349 +15
+ Misses 996 995 -1
- Partials 416 417 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate to SCTP options API.