Skip to content

Migrate to SCTP options API#3397

Merged
JoTurk merged 1 commit intomasterfrom
sctp-options
Mar 21, 2026
Merged

Migrate to SCTP options API#3397
JoTurk merged 1 commit intomasterfrom
sctp-options

Conversation

@JoTurk
Copy link
Copy Markdown
Member

@JoTurk JoTurk commented Mar 21, 2026

Description

Migrate to SCTP options API.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates SCTP association creation from the sctp.Config struct API to the newer ClientWithOptions functional options API, updating dependency versions accordingly.

Changes:

  • Replace sctp.Client(sctp.Config{...}) usage with sctp.ClientWithOptions(...) in SCTPTransport.Start.
  • Introduce helper methods to build the SCTP client options list, including conditional (optional) options.
  • Add a unit test to ensure optional SCTP options are included when enabled, and bump github.com/pion/sctp to v1.9.3.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
sctptransport.go Migrates SCTP client initialization to ClientWithOptions and centralizes option construction.
sctptransport_test.go Adds coverage ensuring optional SCTP settings result in additional options being passed.
go.mod Updates github.com/pion/sctp dependency to v1.9.3.
go.sum Updates checksums corresponding to the SCTP dependency bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JoTurk JoTurk merged commit b409f21 into master Mar 21, 2026
24 checks passed
@JoTurk JoTurk deleted the sctp-options branch March 21, 2026 14:43
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.53%. Comparing base (87b7c3e) to head (b409f21).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3397      +/-   ##
==========================================
+ Coverage   85.51%   85.53%   +0.02%     
==========================================
  Files          81       81              
  Lines        9746     9761      +15     
==========================================
+ Hits         8334     8349      +15     
+ Misses        996      995       -1     
- Partials      416      417       +1     
Flag Coverage Δ
go 85.53% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants