Updating to [email protected] #45
Conversation
fixed run init to call new build script
|
Hello,
|
| @@ -107,7 +107,6 @@ SystemJS.config({ | |||
| "url": "npm:[email protected]", | |||
| "util": "npm:[email protected]", | |||
| "vm": "npm:[email protected]", | |||
| "whatwg-fetch": "npm:[email protected]", | |||
There was a problem hiding this comment.
no you cannot remove it, types was added to types lib, not the polyfill
scripts/build.js
Outdated
| @@ -2,7 +2,8 @@ require('shelljs/global'); | |||
|
|
|||
| const package = require('../package.json'); | |||
| const prodDependencies = Object.keys(package.jspm.dependencies); | |||
| const devDependencies = Object.keys(package.jspm.devDependencies); | |||
| const devDependencies = Object.keys(package.jspm.devDependencies) | |||
| .filter((package) => package !== "systemjs-hot-reloader"); | |||
There was a problem hiding this comment.
this is unnecessary, as you need this in dev hot reloading
There was a problem hiding this comment.
this was a workaround for an issue i found with bundling systemjs-hot-reloader.
alexisvincent/systemjs-hot-reloader#138
I'll see if i can get a reply on what needs to be configured.
There was a problem hiding this comment.
ah I see, good to know, I gonna try as well if it works for me
| @@ -1,6 +1,6 @@ | |||
| // lib imports | |||
| import * as React from 'react'; | |||
| import * as ReactDOM from 'react-dom'; | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
import statements should be changed back to namespace, as we want to import namespace and not default export
There was a problem hiding this comment.
Hrmm. I had a lot of problems with this. I updated systemjs/builder#775 to see if i can get some help to get the namespace import working again.
There was a problem hiding this comment.
@wongwill86 I think that if React is not supporting ES Module flag we should probably stick to default import, this is really annoying because we will not be able to use named import as well, but unfortunately I couldn't find any good workaround ;/
| import { connect } from 'react-redux'; | ||
| import { returntypeof } from 'react-redux-typescript'; | ||
| import RRT from 'react-redux-typescript'; |
|
there is a bigger issue going on regarding commonjs modules: systemjs/systemjs#1587 |
|
@wongwill86 thanks for contribution For me it seems 0.20 update introduce too much issues for existing users of boilerplate that it is not worth currently. Thanks for help |
|
no problem i hope it helps. That makes sense. thanks for reviewing! |
I had to update the package on my fork because [email protected] reloading did not trigger parent dependency updates for plugin-text (i.e. module that imports text file does not update when text file is updated). Updating to v1.1.0 seems to fix this issue.
Here's a PR in case you were planning to update these dependencies.
Updating to systemjs-hot-reloader@ 1.1.0 requires updating jspm/systemjs.
New breaking changes in SystemJS@ 0.20.x due to NodeJS ES Module directions http://guybedford.com/systemjs-alignment.
Now cjs modules need to be compiled with
__esModulesin order forimport { name } from 'cjs.js'exports.__esModules = true.Tried using systemjs configuration via esModule option but it doesn't seem to be working: esModule option is ignored systemjs/builder#775
Unit testing seemed to have broke with
moduleNameMapperseemed to allow Jest to resolve thisAlso, side note, Jest doesn't seem to support JSPM/Systemjs correctly :
http://stackoverflow.com/questions/32945193/jest-testing-with-es6-jspm-systemjs-reactjs